Skip to content

fix(CI): repair shellcheck findings and stale rules symlink #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mxriverlynn merged 1 commit into from
Jul 14, 2026
Merged

fix(CI): repair shellcheck findings and stale rules symlink #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .claude/rules/plugin-entity-taxonomy.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
../../docs/guidance/plugin-entity-taxonomy.md
../../han-plugin-builder/skills/guidance/references/plugin-entity-taxonomy.md
3 changes: 1 addition & 2 deletions han-github/skills/work-items-to-issues/scripts/upload-screenshots.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,7 @@ put_file() {
# authenticated viewers, so the issue body is correct.
verify_on() {
local branch="$1" api_path="$2"
local attempt
for attempt in 1 2 3 4 5; do
for _ in 1 2 3 4 5; do
if gh api "$api_path?ref=$branch" --jq .sha >/dev/null 2>&1; then
return 0
fi
Expand Down
1 change: 1 addition & 0 deletions han-plugin-builder/skills/guidance/scripts/init-guidance.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ RULE=".claude/rules/plugin-building-guidance.md"
rewrite_skill() {
file="$1"
tmp="$(mktemp)"
# shellcheck disable=SC2016 # ${CLAUDE_PLUGIN_ROOT} is matched literally, not expanded.
sed \
-e 's|${CLAUDE_PLUGIN_ROOT}/skills/guidance/references/|.claude/skills/plugin-guidance/references/|g' \
-e 's|^name: guidance$|name: plugin-guidance|' \
Expand Down
Loading