fix(prefer-find-by): stop prefer-find-by fixer to break code when no …

[dyatko]

…spaces before bracket

Checks

• I have read the contributing guidelines.
• If some rule is added/updated/removed, I've regenerated the rules list.
• If some rule meta info is changed, I've regenerated the plugin shared configs.

Changes

Add check for spaces before brackets for prefer-find-by fixer

Context

The rule fixer didn't assume that some codebases may not separate brackets with spaces, so it's braking the code:

-        const {getByLabelText, getByTestId, getByText} = await renderComponent();
+        const {getByLabelText, getByTestId, getByTex, findByText} = await renderComponent();

[Belco90]

Hi @dyatko!

Good catch! And thank you very much for opening a PR with the fix, I really appreciate it.

It looks good to me, just a small question about if we could make it even more generic. Don't sweat it if it seems an overengineering solution, the current version is better than before!

[Belco90]

Great! Thanks again for your contribution.

[Belco90]

Getting really weird errors in the pipeline when running the tests. I'll have to take a look, no idea what's happening at first sight.

[dyatko]

@Belco90 yeah, same issues in another PR #465

[Belco90]

@Belco90 yeah, same issues in another PR #465

That's a different issue actually: you can see how it's failing to try to install some dependencies.

Our error is caused by Node v16.9.0: nodejs/node#40030

We need to avoid this version meanwhile and stick to v16.8.0. I'm gonna create a PR to stick that Node version our GitHub Actions, so we can get that change here.

[Belco90]

Pull request created: #473

[github-actions]

🎉 This PR is included in version 4.12.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[Belco90]

@all-contributors please add @dyatko for bug and code

[allcontributors]

@Belco90

I've put up a pull request to add @dyatko! 🎉