Skip to content

Fixed 'cert_trust_wildcard' identifier when multiple certificates are…#3059

Open
TheraNinjaCat wants to merge 1 commit into
testssl:3.3devfrom
TheraNinjaCat:fix-cert-trust-wildcard-identifier-3051
Open

Fixed 'cert_trust_wildcard' identifier when multiple certificates are…#3059
TheraNinjaCat wants to merge 1 commit into
testssl:3.3devfrom
TheraNinjaCat:fix-cert-trust-wildcard-identifier-3051

Conversation

@TheraNinjaCat

Copy link
Copy Markdown

Describe your changes

This is a very small change to address the issue raised in #3051 to make the cert_trust_wildcard identifier consistent when multiple server certificates are present.

While this was closed as not planned, I disagree with the idea that it's not a bug, as everything about the current behavior feels inconsistent, especially as the identifier is correct when only a single server certificate is present.

What is your pull request about?

  • Bug fix
  • Improvement
  • New feature (adds functionality)
  • Breaking change (bug fix, feature or improvement that would cause existing functionality to not work as expected)
  • Typo fix
  • Documentation update
  • Update of other files

If it's a code change please check the boxes which are applicable

  • For the main program: My edits contain no tabs, indentation is five spaces and any line endings do not contain any blank chars
  • I've read CONTRIBUTING.md and Coding_Convention.md
  • I have tested this fix or improvement against >=2 hosts and I couldn't spot a problem
  • I have tested this new feature against >=2 hosts which show this feature and >=2 host which does not (in order to avoid side effects) . I couldn't spot a problem
  • For the new feature I have made corresponding changes to the documentation and / or to help()
  • If it's a bigger change: I added myself to CREDITS.md (alphabetical order) and the change to CHANGELOG.md

@drwetter

Copy link
Copy Markdown
Collaborator

I'll look into it again next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants