Fixed 'cert_trust_wildcard' identifier when multiple certificates are…#3059
Open
TheraNinjaCat wants to merge 1 commit into
Open
Fixed 'cert_trust_wildcard' identifier when multiple certificates are…#3059TheraNinjaCat wants to merge 1 commit into
TheraNinjaCat wants to merge 1 commit into
Conversation
Collaborator
|
I'll look into it again next week |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
This is a very small change to address the issue raised in #3051 to make the
cert_trust_wildcardidentifier consistent when multiple server certificates are present.While this was closed as not planned, I disagree with the idea that it's not a bug, as everything about the current behavior feels inconsistent, especially as the identifier is correct when only a single server certificate is present.
What is your pull request about?
If it's a code change please check the boxes which are applicable
help()