Add Features Support to sm.ini#11
Open
Dracrius wants to merge 13 commits into
Open
Conversation
Setup support for [Features] section of ini with current features - AmmoRechargeStation : Missile stations will refill super missiles and power bomb - ShinesparkControl : Control the shinespark in any direction - ChainSpark : Resume speed boosting from slope - LowHealthBeep : Lower volume of low health beep - PowerBombReveal : Power bombs reveal super missile blocks - InstantPickups : Quick pickups Based on code implementation LowHealthBeep could be changed from a bool to a value and used to set how much to lower the volume by.
…e issue noted in merge testyourmine#3
LaserEyess
reviewed
Jul 19, 2024
LaserEyess
reviewed
Jul 19, 2024
… but was written to) Swapped Feature enum assignment to hex values
…and fixed the features address to one that has room for a uint32
…ni setting for when someone does get around to fixing extended y
… a new setting to the ini for it.
…riginal placement caused build issues when creating a switch build.
…d the default Audio Frequency to match the old hardcoded one.
…reveal) Hardcoded Switch builds to use fullscreen to avoid stretched widescreen from windowed mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Patched in the enhanced feature support used in previous snesrev projects to allow configuration of Super Metroid's extra features through the ini. Also allowed for the use of both a sm.smc or sm.sfc rom.
Will this Pull Request break anything?
No
Suggested Testing Steps
Double check replay compatibility and that all features enable correctly. I personally don't have a save that allows me to test all of the features I just tested with some debug outputs.