Add Monero-Carrot coin derivation path#16
Open
jeffro256 wants to merge 1 commit intotevador:masterfrom
Open
Conversation
Calling code is meant to call `polyseed_decode(... POLYSEED_MONERO ... )` to preserve backwards compatibility with existing seeds, and call `polyseed_keygen(... POLYSEED_MONERO_CARROT ...)` to generate new Carrot key material, since we can't reuse the old key material for post-quantum privacy's sake. We just need to reserve this coin code so it doesn't get used for something else / is standardized.
Owner
|
Has this derivation path been implemented in any wallet software? It seems there are already other coins using this code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling code is meant to call
polyseed_decode(... POLYSEED_MONERO ... )to preserve backwards compatibility with existing seeds, and callpolyseed_keygen(... POLYSEED_MONERO_CARROT ...)to generate new Carrot key material, since we can't reuse the old key material for post-quantum privacy's sake. We just need to reserve this coin code so it doesn't get used for something else / is standardized. Modifying the salt, while using the same seed, in the KDF solves all of our engineering concerns as it relates to Polyseed and Carrot migrations, so it's just a question of taste.Resolves #15