feat(dursto): Round-trip of Normal-Proof-Verify for MAVL Tree for non-structural-change operations

[NSant215]

Closes RV-962.
Part of RV-961.

What

Introduce MerkleProofFold and PartialHashFold implementations over MAVL objects to allow for proof production and verification.

Why

Working towards completing proof support in DS.

How

Manually Testing

make all

Tasks for the Author

• Link all Linear issues related to this MR using magic words (e.g. part of, relates to, closes).
• Eliminate dead code and other spurious artefacts introduced in your changes.
• Document new public functions, methods and types.
• Make sure the documentation for updated functions, methods, and types is correct.
• Add tests for bugs that have been fixed.
• Explain changes to regression test captures when applicable.
• Write commit messages in agreement with our guidelines.
• Self-review your changes to ensure they are high-quality.
• Complete all of the above before assigning this MR to reviewers.

[codecov]

Codecov Report

❌ Patch coverage is 82.20339% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.70%. Comparing base (3c5cd88) to head (9e0aac7).

Files with missing lines	Patch %	Lines
durable-storage/src/avl/resolver.rs	79.12%	18 Missing and 1 partial ⚠️
durable-storage/src/avl/tree.rs	90.47%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #989      +/-   ##
==========================================
+ Coverage   89.66%   89.70%   +0.04%     
==========================================
  Files         125      125              
  Lines       26985    27103     +118     
  Branches    26985    27103     +118     
==========================================
+ Hits        24196    24314     +118     
+ Misses       2156     2143      -13     
- Partials      633      646      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

Benchmark results for revision 4abff73:

Metric	Duration	TPS
Mean	1.521297922s	26.294
Worst	1.5340372s	26.075
Best	1.512008113s	26.455
Standard Deviation	±4.523764ms	±0.078

Full results

Run	Transfers	Duration	TPS
1	40	1.52524962s	26.225
2	40	1.525788753s	26.216
3	40	1.523278926s	26.259
4	40	1.521834564s	26.284
5	40	1.519272914s	26.328
6	40	1.525075599s	26.228
7	40	1.520343281s	26.310
8	40	1.518200864s	26.347
9	40	1.522238498s	26.277
10	40	1.517812962s	26.354
11	40	1.5340372s	26.075
12	40	1.520033861s	26.315
13	40	1.524088582s	26.245
14	40	1.524584585s	26.237
15	40	1.518179665s	26.347
16	40	1.515643862s	26.391
17	40	1.519780169s	26.320
18	40	1.512008113s	26.455
19	40	1.521021545s	26.298
20	40	1.51748487s	26.359

Compare the results above with those for the default branch.

[emturner]

Closes RV-961.

Possibly, could you split that issue up into two sub issues? (we should follow up with delete and insert)

[victor-dumitrescu]

I mostly reviewed the test, IIUC most trait implementations will have to change in order to support structural changes?

[emturner]

I mostly reviewed the test, IIUC most trait implementations will have to change in order to support structural changes?

They will - mainly just trying to get something working so we have more context as to how things break as we introduce the structural changes