Skip to content

refactor(blob-store): blob store error type#990

Open
thomasathorne wants to merge 1 commit intomainfrom
thomasa/blob-store-error
Open

refactor(blob-store): blob store error type#990
thomasathorne wants to merge 1 commit intomainfrom
thomasa/blob-store-error

Conversation

@thomasathorne
Copy link
Copy Markdown
Contributor

@thomasathorne thomasathorne commented Apr 9, 2026

Part of TZX-86.

What

Switch from an associated error type in the BlobStore trait to a dedicated BlobStoreError enum representing the common errors that a blob store may experience (with a Custom variant for other errors associated with specific implementations).

Why

This is an approach that is easier to integrate into other error types such as the existing StorageError in the PVM storage module, which will happen in a follow up PR.

Manually Testing

make all

Tasks for the Author

  • Link all Linear issues related to this MR using magic words (e.g. part of, relates to, closes).
  • Eliminate dead code and other spurious artefacts introduced in your changes.
  • Document new public functions, methods and types.
  • Make sure the documentation for updated functions, methods, and types is correct.
  • Add tests for bugs that have been fixed.
  • Explain changes to regression test captures when applicable.
  • Write commit messages in agreement with our guidelines.
  • Self-review your changes to ensure they are high-quality.
  • Complete all of the above before assigning this MR to reviewers.

@thomasathorne thomasathorne force-pushed the thomasa/blob-store-error branch 2 times, most recently from 5c5f6a4 to 3019a7c Compare April 9, 2026 16:59
@thomasathorne thomasathorne changed the title feat(data): blob store error type refactor(blob-store): blob store error type Apr 9, 2026
@thomasathorne thomasathorne force-pushed the thomasa/blob-store-error branch 2 times, most recently from 7fc2ad3 to 741f5e7 Compare April 9, 2026 17:17
@thomasathorne thomasathorne force-pushed the thomasa/blob-store-error branch from 741f5e7 to c8ee9b4 Compare April 9, 2026 17:22
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026

Codecov Report

❌ Patch coverage is 75.75758% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.54%. Comparing base (bbf9876) to head (c8ee9b4).

Files with missing lines Patch % Lines
data/src/store.rs 42.85% 4 Missing ⚠️
pvm/src/storage.rs 78.57% 2 Missing and 1 partial ⚠️
data/src/store/fold.rs 91.66% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (75.75%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #990      +/-   ##
==========================================
- Coverage   89.59%   89.54%   -0.05%     
==========================================
  Files         125      125              
  Lines       26863    26879      +16     
  Branches    26863    26879      +16     
==========================================
+ Hits        24067    24069       +2     
- Misses       2166     2180      +14     
  Partials      630      630              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@thomasathorne thomasathorne marked this pull request as ready for review April 10, 2026 09:49
@github-actions
Copy link
Copy Markdown

Benchmark results for revision 3af423f:

Metric Duration TPS
Mean 1.519150327s 26.331
Worst 1.52671797s 26.200
Best 1.513712024s 26.425
Standard Deviation ±3.259044ms ±0.056
Full results
Run Transfers Duration TPS
1 40 1.52671797s 26.200
2 40 1.519924723s 26.317
3 40 1.518943436s 26.334
4 40 1.520054628s 26.315
5 40 1.521492468s 26.290
6 40 1.521276961s 26.294
7 40 1.514108127s 26.418
8 40 1.518588821s 26.340
9 40 1.519968967s 26.316
10 40 1.518723269s 26.338
11 40 1.524138168s 26.244
12 40 1.516372379s 26.379
13 40 1.520472637s 26.308
14 40 1.51994412s 26.317
15 40 1.516924216s 26.369
16 40 1.519792797s 26.319
17 40 1.515523283s 26.394
18 40 1.514158874s 26.417
19 40 1.513712024s 26.425
20 40 1.522168669s 26.278

Compare the results above with those for the default branch.

@thomasathorne thomasathorne enabled auto-merge April 10, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants