refactor(blob-store): blob store error type#990
Open
thomasathorne wants to merge 1 commit intomainfrom
Open
Conversation
5c5f6a4 to
3019a7c
Compare
7fc2ad3 to
741f5e7
Compare
741f5e7 to
c8ee9b4
Compare
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (75.75%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #990 +/- ##
==========================================
- Coverage 89.59% 89.54% -0.05%
==========================================
Files 125 125
Lines 26863 26879 +16
Branches 26863 26879 +16
==========================================
+ Hits 24067 24069 +2
- Misses 2166 2180 +14
Partials 630 630 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Benchmark results for revision 3af423f:
Full results
Compare the results above with those for the default branch. |
emturner
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of TZX-86.
What
Switch from an associated error type in the
BlobStoretrait to a dedicatedBlobStoreErrorenum representing the common errors that a blob store may experience (with aCustomvariant for other errors associated with specific implementations).Why
This is an approach that is easier to integrate into other error types such as the existing
StorageErrorin the PVM storage module, which will happen in a follow up PR.Manually Testing
Tasks for the Author