feat(Merkle): partially implement Verify mode#991
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #991 +/- ##
==========================================
+ Coverage 89.59% 89.60% +0.01%
==========================================
Files 125 125
Lines 26863 26985 +122
Branches 26863 26985 +122
==========================================
+ Hits 24067 24181 +114
- Misses 2166 2171 +5
- Partials 630 633 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ece9634 to
b0729f5
Compare
Adds an implementation of the MerkleLayer using `Verify` mode. Stubs `MerkleLayerMode::hash`.
b0729f5 to
08db65e
Compare
|
Benchmark results for revision b4a0ebe:
Full results
Compare the results above with those for the default branch. |
emturner
approved these changes
Apr 10, 2026
NSant215
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of RV-959
What
Implements (most of) Verify mode for the Merkle layer
Why
We want to move towards Verify and Prove mode implementations up to the Registry. This is a prerequisite.
How
VerifyImplandMerkleLayer<KV, Verify>::from_verify_treeMerkleLayerModeVerifyTreeId::Defaultimpl and makes default trees present. This makes sense to me as nodes that are created or rebalanced must be present, but is worth revisiting during implementation of the round-trip tests.Doesn't implement proof parsing yet, which needs RV-958 and will allow construction of a
VerifyMerkle layer in production.Manually Testing
Tasks for the Author