test(dursto): Add roundtrip tests of Normal -> Verify for MAVL tree on structural-change operations.#992
Draft
NSant215 wants to merge 1 commit intosantnr/mavlfrom
Draft
test(dursto): Add roundtrip tests of Normal -> Verify for MAVL tree on structural-change operations.#992NSant215 wants to merge 1 commit intosantnr/mavlfrom
NSant215 wants to merge 1 commit intosantnr/mavlfrom
Conversation
d57312d to
f86e5a5
Compare
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (24.66%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## santnr/mavl #992 +/- ##
===============================================
- Coverage 89.70% 89.23% -0.48%
===============================================
Files 125 125
Lines 27103 27273 +170
Branches 27103 27273 +170
===============================================
+ Hits 24314 24338 +24
- Misses 2143 2288 +145
- Partials 646 647 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f86e5a5 to
fac4f2b
Compare
6b2ae98 to
55dca89
Compare
fac4f2b to
72db609
Compare
72db609 to
11bfd3f
Compare
11bfd3f to
1d5bc2b
Compare
…l-change operations
1d5bc2b to
0a81afa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes RV-963.
Closes RV-961.
What
Adds (currently failing) roundtrip tests on the Prove and Verify modes of the MAVL tree with operations involving structural changes of the tree.
Why
The current design is flawed. These operations need to be infallible.
Manually Testing
Tasks for the Author