Skip to content

test(dursto): Add roundtrip tests of Normal -> Verify for MAVL tree on structural-change operations.#992

Draft
NSant215 wants to merge 1 commit intosantnr/mavlfrom
santnr/mavl-rotate
Draft

test(dursto): Add roundtrip tests of Normal -> Verify for MAVL tree on structural-change operations.#992
NSant215 wants to merge 1 commit intosantnr/mavlfrom
santnr/mavl-rotate

Conversation

@NSant215
Copy link
Copy Markdown
Contributor

@NSant215 NSant215 commented Apr 10, 2026

Closes RV-963.
Closes RV-961.

What

Adds (currently failing) roundtrip tests on the Prove and Verify modes of the MAVL tree with operations involving structural changes of the tree.

Why

The current design is flawed. These operations need to be infallible.

Manually Testing

make all

Tasks for the Author

  • Link all Linear issues related to this MR using magic words (e.g. part of, relates to, closes).
  • Eliminate dead code and other spurious artefacts introduced in your changes.
  • Document new public functions, methods and types.
  • Make sure the documentation for updated functions, methods, and types is correct.
  • Add tests for bugs that have been fixed.
  • Explain changes to regression test captures when applicable.
  • Write commit messages in agreement with our guidelines.
  • Self-review your changes to ensure they are high-quality.
  • Complete all of the above before assigning this MR to reviewers.

@NSant215 NSant215 changed the base branch from main to santnr/mavl April 10, 2026 10:46
@NSant215 NSant215 force-pushed the santnr/mavl-rotate branch from d57312d to f86e5a5 Compare April 10, 2026 10:50
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2026

Codecov Report

❌ Patch coverage is 24.66960% with 171 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.23%. Comparing base (9e0aac7) to head (0a81afa).

Files with missing lines Patch % Lines
durable-storage/src/avl/resolver.rs 24.66% 163 Missing and 8 partials ⚠️

❌ Your patch check has failed because the patch coverage (24.66%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@               Coverage Diff               @@
##           santnr/mavl     #992      +/-   ##
===============================================
- Coverage        89.70%   89.23%   -0.48%     
===============================================
  Files              125      125              
  Lines            27103    27273     +170     
  Branches         27103    27273     +170     
===============================================
+ Hits             24314    24338      +24     
- Misses            2143     2288     +145     
- Partials           646      647       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@NSant215 NSant215 force-pushed the santnr/mavl-rotate branch from f86e5a5 to fac4f2b Compare April 10, 2026 15:20
@NSant215 NSant215 force-pushed the santnr/mavl branch 2 times, most recently from 6b2ae98 to 55dca89 Compare April 10, 2026 15:29
@NSant215 NSant215 force-pushed the santnr/mavl-rotate branch from fac4f2b to 72db609 Compare April 10, 2026 15:29
@NSant215 NSant215 force-pushed the santnr/mavl-rotate branch from 72db609 to 11bfd3f Compare April 10, 2026 15:30
@NSant215 NSant215 force-pushed the santnr/mavl-rotate branch from 11bfd3f to 1d5bc2b Compare April 10, 2026 16:32
@NSant215 NSant215 force-pushed the santnr/mavl-rotate branch from 1d5bc2b to 0a81afa Compare April 10, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant