feat(pvm-storage): chunked io using BlobStore#993
Draft
thomasathorne wants to merge 1 commit intothomasa/blob-store-errorfrom
Draft
feat(pvm-storage): chunked io using BlobStore#993thomasathorne wants to merge 1 commit intothomasa/blob-store-errorfrom
BlobStore#993thomasathorne wants to merge 1 commit intothomasa/blob-store-errorfrom
Conversation
3012d88 to
1372f58
Compare
1372f58 to
c4666a9
Compare
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (56.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## thomasa/blob-store-error #993 +/- ##
============================================================
- Coverage 89.54% 89.51% -0.04%
============================================================
Files 125 125
Lines 26879 26896 +17
Branches 26879 26896 +17
============================================================
+ Hits 24069 24076 +7
- Misses 2180 2189 +9
- Partials 630 631 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of TZX-86.
What
Modify the 'chunked IO' methods
commit_serialisedandcheckout_serialisedthat are currently used for PVM storage so that they can run against any implementation of theBlobStoretrait.We also add an extension to that trait,
ExportStore, that allows copying blobs from one store into another at a given filesystem path. This is needed to implement theexport_snapshotmethod. Having this extra trait will make it easier to switch to using the durable-storage persistence-layer, as that can easily be made to implementExportStoreon top ofBlobStore.Why
We want to benchmark the existing (chunked) commit and checkout as well as the new (folded) methods. If both approaches can be run against an arbitrary
BlobStoreit makes the benchmarking much easier.Manually Testing
Tasks for the Author