ci: add extensible deploy workflow using GitHub Deployments#521
Open
garrappachc wants to merge 3 commits intomasterfrom
Open
ci: add extensible deploy workflow using GitHub Deployments#521garrappachc wants to merge 3 commits intomasterfrom
garrappachc wants to merge 3 commits intomasterfrom
Conversation
Contributor
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds a top-level `permissions: {}` to restrict GITHUB_TOKEN to
read-only by default, satisfying the security scanner requirement.
The deploy job already has its own `permissions: deployments: write`
override for what it actually needs.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ESLint flagged `!` assertions in `getMapWinner` and `pickServer` as unnecessary since the type checker already knows the type. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
0cee3d3 to
b68d986
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/deploy.ymlthat deploys to tf2pickup.pl and tf2pickup.fr via SSH usingdocker composebuildworkflow completes successfully on a release tag (avoids the race condition of triggering on the GitHub release event)tagandenvironmentinputsbobheadxi/deployments) to track deployment history per environment in the GitHub UIExtensibility
Adding a new environment requires only:
ENVIRONMENTSarray in thesetupjobSSH_HOST,SSH_USER,SSH_PRIVATE_KEYsecretsdocker-compose.ymlusingimage: ghcr.io/tf2pickup-org/tf2pickup:${IMAGE_TAG:-stable}🤖 Generated with Claude Code