Draft
Conversation
garrappachc
force-pushed
the
refactor/simplify-launch-game
branch
3 times, most recently
from
5daa8aa to
9d79611
Compare
Contributor
Playwright test results
Details
|
garrappachc
force-pushed
the
refactor/simplify-launch-game
branch
2 times, most recently
from
c2582ea to
eaac1a1
Compare
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…e export Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…test Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ooking Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…onfigure Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ions Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Without an overload, calling findOne() with no pluck argument caused Keys to default to never, making PickDeep<GameModel, never> return an empty type and all downstream property accesses unsafe (triggering @typescript-eslint/no-unsafe-assignment in the API v1 slots route). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
garrappachc
force-pushed
the
refactor/simplify-launch-game
branch
from
9a784a3 to
5164329
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify launch game logic and add a few fixes: