Skip to content

Fixes 3 more bugs #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MrMelbert merged 1 commit into from
Jun 9, 2026
Merged

Fixes 3 more bugs #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 13 additions & 34 deletions dist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33148,7 +33148,7 @@ function GetOwnersWithModifiedFiles(codeowners, modifiedFiles) {
if (!regex_match) {
let regex = ownerPath;
//No slashes at all, match any file at any level
const fileMode = regex.includes('/');
const fileMode = !regex.includes('/');
//Remove leading slash before generating Regex as modified files from PR don't start with slash aka src/code/Program.cs and not /src...
regex = regex.replace('/', '');
//Escape the input
Expand Down Expand Up @@ -33225,41 +33225,20 @@ async function run() {
info('No reviewers to call');
return;
}
//Remove users that have previously removed/added themself to review
;
(await octokit.paginate(octokit.rest.issues.listEvents.endpoint.merge({
owner: core_owner,
repo: core_repo,
issue_number: pull_number
})))
.flatMap(array => array)
.reverse() //reverse to get latest events
.forEach(issue_event => {
const event = issue_event.event;
if (event == 'review_request_removed' ||
event == 'review_requested') {
const remove = issue_event.actor.login;
//skip bot events
if (remove == 'github-actions[bot]') {
return;
}
//if user has triggered this event then we skip it
const index = trimmed_owners.indexOf(remove);
if (index >= 0) {
notice(`User ${remove} has ${event == 'review_request_removed' ? 'previously removed' : 'already added'} themself as a reviewer.`);
trimmed_owners.splice(index, 1);
}
}
});
//Remove Invalid users
for (const user of trimmed_owners.toReversed()) {
const response = await octokit.rest.issues.checkUserCanBeAssigned({
owner: core_owner,
repo: core_repo,
assignee: user
});
if (response.status != 204) {
notice(`User ${user} cannot be requested for review, make sure they are a member of a team with read access.`);
try {
const response = await octokit.rest.issues.checkUserCanBeAssigned({
owner: core_owner,
repo: core_repo,
assignee: user
});
if (response.status != 204) {
throw new Error(`Cannot be requested for review, make sure they are a member of a team with read access.`);
}
}
catch (ex) {
notice(`Error verifying user ${user}: ${ex}`);
trimmed_owners.splice(trimmed_owners.indexOf(user), 1);
}
}
Expand Down
64 changes: 15 additions & 49 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ function GetOwnersWithModifiedFiles(
if (!regex_match) {
let regex = ownerPath
//No slashes at all, match any file at any level
const fileMode = regex.includes('/')
const fileMode = !regex.includes('/')
//Remove leading slash before generating Regex as modified files from PR don't start with slash aka src/code/Program.cs and not /src...
regex = regex.replace('/', '')

Expand Down Expand Up @@ -167,56 +167,22 @@ async function run(): Promise<void> {
return
}

//Remove users that have previously removed/added themself to review
;(
await octokit.paginate<
RestEndpointMethodTypes['issues']['listEvents']['response']['data']
>(
octokit.rest.issues.listEvents.endpoint.merge({
owner: core_owner,
repo: core_repo,
issue_number: pull_number
})
)
)
.flatMap(array => array)
.reverse() //reverse to get latest events
.forEach(issue_event => {
const event = issue_event.event
if (
event == 'review_request_removed' ||
event == 'review_requested'
) {
const remove = issue_event.actor.login

//skip bot events
if (remove == 'github-actions[bot]') {
return
}

//if user has triggered this event then we skip it
const index = trimmed_owners.indexOf(remove)
if (index >= 0) {
notice(
`User ${remove} has ${event == 'review_request_removed' ? 'previously removed' : 'already added'} themself as a reviewer.`
)
trimmed_owners.splice(index, 1)
}
}
})

//Remove Invalid users
for (const user of trimmed_owners.toReversed()) {
const response: RestEndpointMethodTypes['issues']['checkUserCanBeAssigned']['response'] =
await octokit.rest.issues.checkUserCanBeAssigned({
owner: core_owner,
repo: core_repo,
assignee: user
})
if (response.status != 204) {
notice(
`User ${user} cannot be requested for review, make sure they are a member of a team with read access.`
)
try {
const response: RestEndpointMethodTypes['issues']['checkUserCanBeAssigned']['response'] =
await octokit.rest.issues.checkUserCanBeAssigned({
owner: core_owner,
repo: core_repo,
assignee: user
})
if (response.status != 204) {
throw new Error(
`Cannot be requested for review, make sure they are a member of a team with read access.`
)
}
} catch (ex) {
notice(`Error verifying user ${user}: ${ex}`)
trimmed_owners.splice(trimmed_owners.indexOf(user), 1)
}
}
Expand Down