fix: remove pkg_resources asset lookup - #28
Draft
Mirochill wants to merge 1 commit into
Draft
Conversation
Resolve bundled Sphinx asset paths relative to charts.py instead of using pkg_resources.resource_filename. The assets are packaged inside sphinx_charts, so this keeps the existing copy flow without adding a compatibility backport for older supported Python versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pkg_resources.resource_filenameimport fromsphinx_charts.charts_static/sphinx_chartsFixes #26
I opened this against
main, the default branch; happy to retarget if a version branch is preferred.Validation
git diff --check HEAD~1..HEADrg -n 'pkg_resources|resource_filename|get_distribution' .(no matches)