Conversation
chrisjamiecarter
left a comment
chrisjamiecarter
left a comment
There was a problem hiding this comment.
Hey @HKHemanthsharma 👋,
Excellent work on your Exercise Tracker project submission 🎉!
I have performed a peer review. Review/ignore any comments as you wish.
👍 Honestly a great project, I love the design and the implementation. It is unfortunate that the spacing and naming conventions let it down. I only requesting changes as it made the code a lot harder to read and follow than it would have done it is was spaced conventionally.
🔧 Please revisit to try understand and fix any issues marked 🔴, as they block my approval.
Feel free to reach out if you have any questions or if you'd like to collaborate further on any of these points 🆘 .
I will go ahead and wait for you to make your changes, commit and push (which will then notify me) 😊 !
Thanks,
@chrisjamiecarter 👍
| { | ||
| return await Service.Delete(Id); | ||
| } | ||
| } |
There was a problem hiding this comment.
🔴 Code Style
💡 As we are onto the more advanced projects. I will need you to conform to the Academy's code-conventions
❗ Take note of the Spacing section.
There was a problem hiding this comment.
Hi @chrisjamiecarter Thank you for the review, I have adjusted the code to follow code-conventions, added necessary spacings to make code more readable and removed few unused variables flagged by codacy. Please let me know if i have to make any changes Thanks.
chrisjamiecarter
left a comment
chrisjamiecarter
left a comment
There was a problem hiding this comment.
Hey @HKHemanthsharma 👋,
Great job on getting your Exercise Tracker updates pushed through 💪!
🟢 Requirements
⭐ You have fulfilled all of the project requirements!
I will go ahead and mark as approved, keep up the excellent work on the next projects! 😊
Best regards,
@chrisjamiecarter 👍
|
PS @HKHemanthsharma please can you close this PR? |
2 participants
looking forward to the Review on this one, the ExerciseTracker.API and ExerciseTracker.UI projects reside in the same solution.
highly appreciate any suggestions on folder structures and API rersponse model designs. let me know where i am doing wrong so that i can improve. Thanks