Open
Conversation
chrisjamiecarter
approved these changes
Aug 31, 2025
chrisjamiecarter
left a comment
chrisjamiecarter
left a comment
There was a problem hiding this comment.
Hey @GoldRino456 👋,
Excellent work on your Ecommerce API project submission 🎉!
I have performed a peer review. Review/ignore any comments as you wish.
🟢 Requirements
⭐ You have fulfilled all of the project requirements!
I will go ahead and mark as approved, keep up the excellent work on the next projects! 😊
Best regards,
@chrisjamiecarter 👍
| using Microsoft.EntityFrameworkCore; | ||
| using System.Text.Json.Serialization; | ||
|
|
||
| var builder = WebApplication.CreateBuilder(args); |
| [HttpGet] | ||
| public async Task<ActionResult<PagedResponse<GameProductResponseDto>>> GetAllGamesAsync([FromQuery] PaginationParams pagination, [FromQuery] GameProductFilterParams filters) | ||
| { | ||
| var query = _gamesService.GetAllGames(); |
There was a problem hiding this comment.
🟠 Not in Controller
💡 I would recommend you pass the responsibility down to your service, then repo. Currently if you filter to 1 record, you get all from the database, and then filter in memory. EFCore can do all this for you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.