Skip to content

Api App completed#91

Open
FreddyPositive wants to merge 2 commits intothe-csharp-academy:mainfrom
FreddyPositive:main
Open

Api App completed#91
FreddyPositive wants to merge 2 commits intothe-csharp-academy:mainfrom
FreddyPositive:main

Conversation

@FreddyPositive
Copy link
Copy Markdown

No description provided.

@FreddyPositive
Copy link
Copy Markdown
Author

is there anything wrong in the code i pushed or no one is there to review ?

Copy link
Copy Markdown

@chrisjamiecarter chrisjamiecarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @FreddyPositive 👋,

Excellent work on your Ecommerce Api project submission 🎉!

I have performed a peer review. Review/ignore any comments as you wish.


🟢 Requirements

⭐ You have fulfilled all of the project requirements!


🟠 Style Guide Compliance

💡 Remember that when you have finished a project, give it a polish pass. Refer to the Academy's code-conventions page.

💭 This is important as good code conventions/styling ensures consistency, makes your code easier for others to read and maintain, and improves your chances of getting a pull request reviewed and approved.


🟠 README File

💡 One way to take your submission to the next level is by including a README file. This small addition can make a big difference!

💭 A README file is like an introduction to your project—it can briefly explain the purpose of your code, provide instructions for running it, and highlight any unique features you've included. It makes your work more accessible to others, whether they're peers, mentors, or even future employers.


I will go ahead and mark as approved, keep up the excellent work on the next projects! 😊

Best regards,
@chrisjamiecarter 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants