Project Completion Submission - Sports Results Notifier

[JJHH17]

This project:

• Scrapes data from a site using the HTML Agility Pack.
• Uses the SendGrid API for sending emails.
• All credentials and details can be found via the app.config file.

[chrisjamiecarter]

Hey @JJHH17 👋,

Excellent work on your Sports Results project submission 🎉!

I have performed a peer review. Review/ignore any comments as you wish.

---

🔴 Missing Requirement

🐞 This is an application where you should read sports data from a website once a day and send it to a specific e-mail address.

❗ As per the projects requirements, where is your once a day implementation? I was expecting a background service or polling mechanism.

---

🟠 Style Guide Compliance

💡 Remember that when you have finished a project, give it a polish pass. Refer to the Academy's code-conventions page.

💭 This is important as good code conventions/styling ensures consistency, makes your code easier for others to read and maintain, and improves your chances of getting a pull request reviewed and approved.

---

🟠 Namespaces

💡 As per the academy's code-conventions, use file-scoped namespaces.

➡️ From C# 10, we are able to remove the block/braces and save on level of indentation, optimising space and improving readability.

---

🟠 README Location

💡 Remember, you are writing a README for your project submission, not the code reviews repository, this file should be in your project submission folder.

📁 CodeReviews.Console.SportsResults
 ┣ 📄 .codacy.yml
 ┣ 📄 .gitignore
 ┣ 📁 SportsResults.JJHH17
 ┃  ┗ 📄 SportsResults.sln
 ┃  ┗ 📄 README.md ⬅️ Goes here!
 ┃  ┗ 📁 SportsResults.Console

---

🔧 Next Steps

• Please fix any 🔴 items, as they block approval.
• Commit and push your changes, then leave me a comment when done.
• Feel free to reach out if you have any questions or want to discuss further 🆘.

Thanks,
@chrisjamiecarter 👍

[JJHH17]

Hi @chrisjamiecarter / team.

Thanks for this feedback, I appreciate the depth and feedback here.

I've made a few changes to this project now:

• Added scheduling of the email, which is done via a cron schedule, using the Cronos NuGet package.
• Removed the unneeded name spacing indentation.

[chrisjamiecarter]

Hey @JJHH17 👋,

💪 Great work on pushing through your updates!

---

🟢 Requirements

⭐ You have fulfilled all of the project requirements!

---

I will go ahead and mark as approved, keep up the excellent work on the next projects! 😊

Best regards,
@chrisjamiecarter 👍