docs: clarify npm test scope in contributing guide#430
Open
haosenwang1018 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- Clarify that
npm testruns the fast suite only\n- Document that integration tests are excluded fromnpm test\n- Add the correct command for integration tests:npm run test:slow\n\n## Why\nThe previous wording saidnpm testruns all tests intests/**/*.test.js, which is inconsistent with the actual npm script inpackage.json. This update aligns CONTRIBUTING docs with real behavior to reduce contributor confusion.\n\n## Local validation\n-npm ci --ignore-scripts\n-npx mocha tests/model-selection.test.js(10 passing)