fix(provider-detection): detect CLIs on Windows via where (fixes #515)#516
Merged
tomdps merged 1 commit intoJun 22, 2026
Merged
Conversation
…cted commandExists/getCommandPath probed for CLIs with the POSIX builtin `command -v`, which does not exist under cmd.exe. On Windows every probe threw, so `zeroshot providers` reported all providers as "not found" even when installed and on PATH. Branch on platform (mirroring src/preflight.js): use `where` on win32 and `command -v` elsewhere. getCommandPath takes the first match line since `where` can return several. Adds cross-platform unit coverage.
This was referenced Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Windows,
zeroshot providersreports every provider as✗ not found, even when the CLI is installed and onPATH(claude --versionworks fine). This makes zeroshot unusable on Windows out of the box.Fixes #515.
Root cause
lib/provider-detection.jsprobes for a CLI with the POSIX shell builtincommand -v:On Windows
execSyncruns throughcmd.exe, which has nocommandbuiltin, so the probe always throws andcommandExists/getCommandPathalways fail. The project already solves this correctly insrc/preflight.js(process.platform === 'win32' ? 'where' : 'which'), but the provider-detection helpers never got the Windows branch.Fix
Branch on platform, mirroring
src/preflight.js:getCommandPathnow takes the first line of output, sincewherecan return multiple matches.Tests
Adds
tests/provider-detection.test.js(mocha + sinon) covering both probe branches and the multi-match path. All 6 pass; lint clean.Verified locally on Windows 11 — after the fix, installed providers flip to
✓ found:Scope note (follow-up)
getHelpOutput/getVersionOutputin the same file callspawnSync(command, ...)withoutshell: true. On Windows that also fails for.cmd/.ps1shims (most npm-installed CLIs). Left out to keep this PR focused on the reported detection bug; happy to add a follow-up if you'd like it bundled.