Skip to content

Make monitoring feedback actionable - #9

Merged
theMobiusStrip merged 1 commit into
mainfrom
agent/actionable-monitoring-feedback
Jul 22, 2026
Merged

Make monitoring feedback actionable#9
theMobiusStrip merged 1 commit into
mainfrom
agent/actionable-monitoring-feedback

Conversation

@theMobiusStrip

Copy link
Copy Markdown
Owner

Summary

  • distinguish configured integrations from verified per-agent event delivery and surface health in the collapsed notch and menu bar
  • make danger, session, and usage notifications open their relevant destination while coalescing overlapping alerts
  • keep install and Doctor work asynchronous, display results beside the affected integration, and represent mixed Doctor outcomes accurately
  • cover verification persistence, notification coalescing, exact detection routing, and structured Doctor outcomes in the selftest

Why

Static hook configuration could look healthy before Perch had received a real event. Notifications also lacked useful destinations, while setup results and mixed Doctor checks could communicate success too broadly.

Impact

Monitoring state is more honest and easier to act on without changing Perch's observe-only boundary. Hook changes invalidate prior delivery verification, and notifications now lead directly to the relevant local context.

Validation

  • make test
  • make fitness
  • rendered showcase inspection

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9610395c33

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Task { @MainActor in
health.noteEvent()
if envelope.kind == .hook {
health.noteEvent(agent: envelope.agent)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Move verification persistence off the sync hook path

For PreToolUse/PermissionRequest, the bridge waits for store.handleEnvelope to invoke reply(.empty), but this new call runs before that and noteEvent can synchronously persistVerification() on the first event and then once per minute. If the config-file write is slow or stuck, these sync hooks are delayed or can hit the bridge timeout even though Perch is supposed to observe without blocking agent actions; record the event after the handler replies or persist asynchronously.

AGENTS.md reference: AGENTS.md:L38-L42

Useful? React with 👍 / 👎.

@theMobiusStrip
theMobiusStrip merged commit 38ab08f into main Jul 22, 2026
1 check passed
@theMobiusStrip
theMobiusStrip deleted the agent/actionable-monitoring-feedback branch July 22, 2026 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant