fix: use go-qrllib 0.1.0 and sign with hexseeds or SK files#16
Merged
jplomas merged 2 commits intotheQRL:mainfrom Nov 18, 2025
Merged
fix: use go-qrllib 0.1.0 and sign with hexseeds or SK files#16jplomas merged 2 commits intotheQRL:mainfrom
jplomas merged 2 commits intotheQRL:mainfrom
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Autogenerated PR description:
This pull request introduces support for signing files or strings using either a hexseed or a private key, with automatic detection of key type from a file. It also adds new unit tests for both the
hashandsignpackages, updates dependencies, and includes a new test vector. The most significant changes are grouped below:Key Handling and Signing Enhancements:
--keyfile(-kf) CLI flag to allow signing using a private key or hexseed loaded from a file, with automatic detection of the key type. This includes the newreadKeyFromFilefunction to parse both RFC7468-formatted hexseed and private key files, as well as plain hexseed strings. The CLI now prevents using both--hexseedand--keyfilesimultaneously and handles key type detection for signing operations. (main.go[1] [2] [3] [4]signpackage to support signing with a private key directly:SignMessageWithPrivateKey,SignFileWithPrivateKey, andSignStringWithPrivateKey. (sign/sign.go[1] [2]Testing Improvements:
hashpackage, covering all supported hash functions with expected outputs. (hash/hash_test.gohash/hash_test.goR1-R95)SignStringin thesignpackage to verify signature length. (sign/sign_test.gosign/sign_test.goR1-R17)Dependency and Import Updates:
go-qrllibdependency to versionv0.1.0ingo.mod. (go.modgo.modL9-R9)dilithiumto reflect its new location ingo-qrllib/crypto/dilithium. (main.go[1]sign/sign.go[2]Other Additions:
deployment.pk.asc).test_vectors/ascii.txt.