Fix: Check math.IsNaN and math.IsInf to prevent ActionRefactorFirst panics#503
Fix: Check math.IsNaN and math.IsInf to prevent ActionRefactorFirst panics#503theRebelliousNerd wants to merge 1 commit into
Conversation
Co-authored-by: theRebelliousNerd <187437903+theRebelliousNerd@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The
parseNumberfunction insideinternal/campaign/edge_case_detector.goused to incorrectly parse and coerce float32/float64 without validating whether those values aremath.NaNormath.Inf. Downstream code relying on the parsing function for numerical complexity calculations could potentially go into infinite loops or permanently trigger action statuses due to incorrect coercion.This PR correctly applies
math.IsNaNandmath.IsInfconditions check to block NaN/Inf values, ensuring invalid mathematical properties return0andfalse. The existing unit test inedge_case_detector_gaps_test.gohas been adjusted to handle the new return types and edge cases gracefully.PR created automatically by Jules for task 17565918586752754377 started by @theRebelliousNerd