🧹 [Code Health] Fix parseNumber handling NaN and +Inf in edge_case_detector.go

[theRebelliousNerd]

🎯 What: Handled math.NaN() and math.Inf(1) edge cases in parseNumber function to correctly return false when trying to convert these values. It prevents math panic/infinity complexities calculation bugs.

💡 Why: Ensuring that inputs are valid float64 types guarantees that other dependent processes don't throw unexpected errors during evaluation of maxComplexity rules or similar mathematical operations. It clears an identified TODO edge case in the edge_case_detector.go.

✅ Verification:

• Validated tests correctly check whether math.NaN() and math.Inf() bypass parsing.
• Wrote an isolated test TestEdgeCaseDetector_ParseNumber with unit tests checking normal types (e.g., int, float64), Invalid types, NaN and Inf properties.
• Passed full test suite (go test $(go list ./... | grep -v cmd/nerd/ui)).

✨ Result: Enhanced the resilience of parseNumber against malformed outputs that the system generates without degrading existing logic. Allowed removing the TODO for edge cases related to coercion parsing bounds safely.

---

PR created automatically by Jules for task 15685713360237823794 started by @theRebelliousNerd

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

Warning

Rate limit exceeded

@theRebelliousNerd has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 44 minutes and 33 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 07a5b21d-e5de-498e-8623-eed379b2c169

📥 Commits

Reviewing files that changed from the base of the PR and between cc0e10f and fb7d953.

📒 Files selected for processing (3)

• internal/campaign/edge_case_detector.go
• internal/campaign/edge_case_detector_gaps_test.go
• internal/campaign/edge_case_detector_test.go

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix-parseNumber-nan-inf-15685713360237823794

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}