🔒 Fix potential command injection/path traversal in nerd tool run#521
🔒 Fix potential command injection/path traversal in nerd tool run#521theRebelliousNerd wants to merge 1 commit into
Conversation
🎯 What: Prevent unauthorized execution by validating the tool binary path in cmd/nerd/cmd_advanced.go.⚠️ Risk: If the binaryPath could somehow be spoofed to escape the expected compiled tools directory, it would allow arbitrary local command execution. 🛡️ Solution: Resolve expected and actual paths via absolute resolution, and strictly verify via filepath.Rel that the target binary resides entirely within the .nerd/tools/.compiled/ directory and physically exists before executing. Co-authored-by: theRebelliousNerd <187437903+theRebelliousNerd@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎯 What: Prevented unauthorized execution by validating the tool binary path before running it in
⚠️ Risk: The previous code pulled
cmd/nerd/cmd_advanced.go.binaryPathfrom a Mangle kernel facttool_binary_pathwithout checking if the binary actually belonged to the internal compiled tools directory. If an attacker managed to assert a malicioustool_binary_path(e.g.../../../../bin/bash), they could execute arbitrary binaries with the same privileges as the agent.🛡️ Solution: Ensure absolute path resolution for both the target binary and the expected directory (
.nerd/tools/.compiled). Usefilepath.Relto explicitly verify that the binary resides strictly within the compiled directory, effectively preventing path traversal escapes and executing untrusted/unexpected binaries on the host system.PR created automatically by Jules for task 10118650433690199416 started by @theRebelliousNerd