chore(lint): clean Biome findings, align rules with tsconfig#27
Merged
Conversation
Brings the repo to zero Biome warnings / infos / errors. Three changes: 1. Disable `lint/complexity/useLiteralKeys` globally. It actively conflicts with the tsconfig's `noPropertyAccessFromIndexSignature: true` — Biome wants `record.key` while the TypeScript compiler requires `record["key"]` on Record-typed index signatures. tsconfig wins; Biome rule gets switched off. Drops 480 infos and lets us remove 10 per-site `biome-ignore` suppression comments that were papering over the conflict. 2. Override `noConsole: off` for `packages/cli/src/commands/**`. CLI commands print to stdout as a feature (verdict output, impact lists, etc.) — those aren't debug statements. Drops 52 warnings. 3. Hand-fix 4 `useTemplate` infos in onnx-embedder.ts and profile.test.ts (concatenation → template literals). Real small-win improvements. Also bumped biome.json `$schema` reference from 2.4.0 → 2.4.12 to match the installed Biome version. Verified: - `pnpm exec biome check .`: 0 errors, 0 warnings, 0 infos - `pnpm -r build`: clean - `pnpm -r exec tsc --noEmit`: clean - `pnpm -r test`: 952 pass / 0 fail - `bash scripts/check-banned-strings.sh`: clean
theagenticguy
force-pushed
the
chore/biome-cleanup
branch
from
e5b4316 to
8eda567
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings the repo to 0 errors / 0 warnings / 0 infos from Biome. Three config changes + 4 small code fixes.
Why the 537 findings were noise, not signal
Before this PR:
lint/complexity/useLiteralKeysrecord.keybut the tsconfig hasnoPropertyAccessFromIndexSignature: true, which requiresrecord["key"]onRecord-typed index signatures. The two rules contradict each other. tsconfig wins.lint/suspicious/noConsolepackages/cli/src/commands/whereconsole.logis how CLI commands emit their primary output (verdict markdown, impact lists, etc.). Not debug leakage.lint/style/useTemplateChanges
biome.jsonlint/complexity/useLiteralKeys:off— resolves the tsconfig conflict, lets us drop 10 per-sitebiome-ignoresuppression comments that were papering over it.overridesentry turning offlint/suspicious/noConsoleforpackages/cli/src/commands/**.$schemabumped from2.4.0→2.4.12to match the installed Biome.Code
packages/embedder/src/onnx-embedder.ts— 2 concat → template literal fixes.packages/ingestion/src/pipeline/phases/profile.test.ts— 2 concat → template literal fixes.// biome-ignore lint/complexity/useLiteralKeyscomments acrossmcp/src/next-step-hints.ts+ test,mcp/src/resources/repo-context.ts,sarif/src/enrich.ts,storage/src/meta.ts. Kept the load-bearing explanatory comment instorage/src/meta.tsthat documents why bracket access is required (tsconfig setting) since that's still non-obvious to readers.Test plan
pnpm exec biome check .→ 0 errors / 0 warnings / 0 infospnpm -r buildcleanpnpm -r exec tsc --noEmitcleanpnpm -r test→ 952 pass / 0 failbash scripts/check-banned-strings.shclean