OTel nest parents, dims, and attribution docs - #41
Open
susheem-k wants to merge 2 commits into
Open
Conversation
Boundaries open a Context stack span before the body so nested LLM/tool nodes parent correctly; trace-level dims flow via record() for dashboard correlation. Document nodes-not-full-agent and multi-turn session/message ids; keep tree/waterfall as debug helpers (#40). Co-authored-by: Cursor <cursoragent@cursor.com>
Full Phoenix registers a pytest plugin that crashes collection on Python 3.11. Split an [otel] extra for SDK/OpenInference; [dev] uses that. [phoenix] still installs the collector/UI on top for users who want it. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parent_envelope_idcorrectly (not last-finished).dims: dict[str, str]on envelopes; pass trace-level dims viachronicle.record(..., dims={...})for session/message correlation (dashboard owns lookup).dims, multi-turnsession_id/message_idin README + onboarding.Sample nesting (ASCII waterfall)
Same sub-agent twice under one parent; each researcher has its own llm + tool envelopes (
fixtures/traces/parent-calls-subagent-twice):Tree form of the same run:
Decision-nodes-only pattern (no full-agent wrap; sequential siblings):
Relation to #40
Partial fix only — does not fully close #40.
parent_span_idfrom Context stack)dims+record(..., dims=)session_id/message_idRefs #40
Test plan
pytest tests/test_nest_attribution.py tests/test_execution_graph.py tests/test_otel.pypyteston CI