Adopt Fallow for client code quality - #39
Merged
Merged
Conversation
Model Umbraco runtime entry points and generated OpenAPI output in client policy, remove real dead code, consolidate dialog lifecycle duplication, and split dashboard initialization paths. Use Lit-aware 35/40 structural health ceilings and a 65/95 render-only override for the connection editor because its independent provider-capability bindings are declarative form branches. Ignore static CRAP until CI emits real Istanbul coverage. Pin Fallow 3.9.1 and gate pull requests against their base SHA.
Restore pair-level duplicate detection and extract all six remaining clone pairs into focused helpers for tabs, dialogs, breakdown footers, date parts, chart state, and initialization results. Lower global health ceilings to cyclomatic 30 and cognitive 35. Keep narrow render-only overrides for the declarative dashboard and connection editor, with finite CRAP ceilings of 300 globally and 900 for the connection form until CI provides real Istanbul coverage.
Remove the extra pnpm argument separator so --base reaches Fallow as an option, and use pnpm directly after the workflow's Corepack enable step.
Make targetTabIndex exhaustive for the four supported keys and preserve the current tab for unrelated keyboard events. Add focused regression coverage for supported and unsupported keys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fallow auditpull-request gatePolicy
minOccurrences: 2renderoverrides for the dashboard and connection editorVerification
corepack pnpm checkcorepack pnpm test— 232 tests passedcorepack pnpm buildnpx fallow— 0 dead-code issues, 0 clone groups, 0 functions above thresholdsnpx fallow dead-code— 0 issuesnpx fallow dupes— 0 clone groups and 0% duplicationnpx fallow health— 610 functions analyzed, 0 above thresholdsnpx fallow audit --base origin/main --gate new-only— pass