Share event and flag drilldown flows - #40
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Events and flags perform the same drill-down interaction, but flags had a parallel implementation and the two flows had diverged. Filtering was consequently inconsistent: active filters could disappear on reload, event filters were omitted from the main filter display, mock data did not change, and Vercel could accept an event-property filter without enough event identity to apply it correctly.
Impact
Events and flags now behave consistently across cards and dialogs. Filters are visible, removable, URL-persistent, close the dialog when selected, and affect demo data. Providers only expose global event-property filtering when they can implement it correctly.
Validation
pnpm checkpnpm test— 257 tests passedpnpm builddotnet test tests/TheBuilder.WebAnalytics.Tests/TheBuilder.WebAnalytics.Tests.csproj --no-restore— 225 tests passedpnpm exec fallowpnpm exec fallow dead-codepnpm exec fallow dupespnpm exec fallow health— 88/Apnpm run audit— no issues in changed filesgit diff --check