Harden OAuth and session handling#4
Conversation
4478b0f to
3633bf8
Compare
|
Hey, I really like where this package is headed. I came from the Node world using Better Auth and was looking for something similar in Go, so Limen felt like the kind of lightweight auth package I wanted to use. While trying it out, I ran into a few small OAuth/OIDC edge cases around ID-token verification, email verification, and account linking. They are not huge issues, but they matter for production auth flows, so I wanted to send a patch instead of just leaving notes. I tried to keep the changes focused and added tests around the risky paths. Happy to adjust anything to better fit the project’s direction. |
|
Hey @ragokan , Thanks for opening this PR. I appreciate you taking the time to contribute to Limen. I’ll take a proper look at it later and leave any feedback or questions directly on the PR. |
Summary
email_verifiedor verified email arrays prove it/user/emails, Discordverified, Facebook/Spotify unverified by defaultVerification notes
subwhen both UserInfo and ID-token claims are present: https://openid.net/specs/openid-connect-core-1_0-18.html#UserInfoResponseTests
for d in $(find . -name go.mod -not -path './examples/*' -exec dirname {} \; | sort); do (cd "$d" && go test -race -count=1 ./...); donegolangci-lint run --new-from-rev upstream/master ./...golangci-lint run ./...passes in changed provider modules: oauth-microsoft, oauth-generic, oauth-github, oauth-discord, oauth-facebook, oauth-spotifygolangci-lint run ./...still reports existinggoconstand cookiegosecbaseline warnings present on upstreammaster