Finish app logic for ratings - #17
Merged
Merged
Conversation
bonbud-macryg
commented
Aug 12, 2023
bonbud-macryg
commented
Aug 12, 2023
bonbud-macryg
commented
Aug 12, 2023
bonbud-macryg
commented
Aug 12, 2023
bonbud-macryg
commented
Aug 12, 2023
bonbud-macryg
commented
Aug 12, 2023
bonbud-macryg
commented
Aug 12, 2023
ashelkovnykov
requested changes
Sep 1, 2023
bonbud-macryg
commented
Sep 3, 2023
bonbud-macryg
commented
Sep 3, 2023
ashelkovnykov
requested changes
Sep 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge candidate, provisionally.
This adds in the remaining logic for ratings in
/app/telosand/lib/telos, with hard-coded placeholder values in+update-player:glicko2.This PR incidentally updates
/sur/glicko2with the current file in PR #12, since%teloswas finally butting up against the outdatedglicko2files in themainbranch.Some new test data was added in the test suite to accommodate the new
+update-player:telosand+compute-ratings-game:telosarms.Only issue I can see with this PR:
=/s in+update-rating:teloscould slow things down. I've asked the Hooniverse about a potential solve for this, which could allow me to output the accumulated result of the|-loop with~and avoid running=/on every recursion.