made the Error type use thiserror#80
Open
kingananas20 wants to merge 2 commits into
Open
Conversation
kingananas20
commented
Jun 5, 2025
| /// Error returned by the crates.io API directly. | ||
| Api(crate::types::ApiErrors), | ||
| } | ||
|
|
Author
There was a problem hiding this comment.
removed everything below because thiserror automatically implements them
kingananas20
changed the title
Author
|
@theduke this change is a breaking change but I could make it so that it's not a breaking change anymore if you want to (or just close this PR). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to use this project but I found that the Error type is not exactly the best (in my opinion, mostly because the url in the
NotFoundstruct wasn't public). So I converted it to use thethiserrorcrate. Yes there are some changes but I think it's better and cleaner now. I tried to keep the error messages the same but I think I discard 2 or 3. Please ask if you don't understand something.