Change call_foreman_api_get 'params' type from dict to JSON string (rebased)#87
Open
schuellerf wants to merge 2 commits into
Open
Change call_foreman_api_get 'params' type from dict to JSON string (rebased)#87schuellerf wants to merge 2 commits into
schuellerf wants to merge 2 commits into
Conversation
Updated the 'params' argument in the call_foreman_api_get function to expect a string (JSON format) instead of a dictionary. This ensures compatibility with MCP client like Langflow.
Use double-quoted string for the JSON example to satisfy ruff format.
ofedoren
reviewed
Feb 16, 2026
| description="Calls GET action on Foreman API.", | ||
| description=( | ||
| "Calls GET action on Foreman API. " | ||
| "The 'params' argument must be a JSON string representing " |
Member
There was a problem hiding this comment.
I'd vote against that, especially if it's mandates the client to send a JSON string only given that this is mostly a workaround for only one (?) client (which is also its issue and should be solved there)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just trying to push this due to PTO
@shzhou12 I hope this is fine for you 😇🙏🙇♂️
This rebases #78 onto
origin/developas of now & fixes the ruff check-- original PR description --
Updated the 'params' argument in the call_foreman_api_get function to expect a string (JSON format) instead of a dictionary. This ensures compatibility with MCP client like Langflow.