Skip to content

Rewrite workflow using reusable actions - #613

Merged
stejskalleos merged 1 commit into
theforeman:developfrom
archanaserver:gha
Jan 23, 2024
Merged

Rewrite workflow using reusable actions#613
stejskalleos merged 1 commit into
theforeman:developfrom
archanaserver:gha

Conversation

@archanaserver

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread .github/workflows/ruby.yml Outdated
Comment thread .github/workflows/ruby.yml
@stejskalleos

Copy link
Copy Markdown
Contributor

I see it's using Ruby 2.7 and Node 14, I was expecting Ruby 3.0 there as well. Or it is planned for later?

@ekohl

ekohl commented Jan 17, 2024

Copy link
Copy Markdown
Member

I see it's using Ruby 2.7 and Node 14, I was expecting Ruby 3.0 there as well. Or it is planned for later?

Planned for later. It reads matrix.json from the target version (defaults to develop, so https://github.com/theforeman/foreman/blob/develop/.github/matrix.json). Once we modify that to include 3.0, that will be tested.

You can take this as a base, similar to theforeman/foreman_remote_execution#864

Comment thread .github/workflows/ruby.yml
@ekohl

ekohl commented Jan 18, 2024

Copy link
Copy Markdown
Member

Packit is failing and #615 should resolve that.

@stejskalleos
stejskalleos merged commit 6aaa8d2 into theforeman:develop Jan 23, 2024
@archanaserver
archanaserver deleted the gha branch January 23, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants