Extend test coverage#91
Merged
Merged
Conversation
stejskalleos
force-pushed
the
ls/tests_ext
branch
from
June 11, 2026 07:47
8d54241 to
c6c7847
Compare
stejskalleos
marked this pull request as ready for review
June 11, 2026 07:48
stejskalleos
force-pushed
the
ls/tests_ext
branch
from
June 11, 2026 07:48
c6c7847 to
a7966ad
Compare
arvind4501
reviewed
Jun 11, 2026
stejskalleos
force-pushed
the
ls/tests_ext
branch
2 times, most recently
from
June 11, 2026 12:16
4931963 to
dad7607
Compare
Collaborator
Author
|
@arvind4501 any other comments or can we merge? |
arvind4501
reviewed
Jun 12, 2026
arvind4501
reviewed
Jun 12, 2026
Co-authored-by: Claude Opus 4.6
stejskalleos
force-pushed
the
ls/tests_ext
branch
from
June 12, 2026 09:51
ab409d7 to
afdc8f6
Compare
evgeni
reviewed
Jun 15, 2026
evgeni
reviewed
Jun 15, 2026
evgeni
reviewed
Jun 15, 2026
evgeni
reviewed
Jun 16, 2026
evgeni
left a comment
Member
There was a problem hiding this comment.
overall this feels a tad too verbose (as expected from AI), but I have no experience with the Google compute integration to judge how useful those tests are
Collaborator
Author
|
🍏 Ruby 3.3 tests are green |
Member
Which part of this PR made them work on 3.3? I thought this is purely a "increase coverage" PR, not "fix compatibility with 3.3"? |
Collaborator
Author
Correct, I just celebrated that 3.3 is green 🥳 |
evgeni
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has been entirely generated by AI.
I want to use it as a proof of concept for extending test coverage in the plugin repository.
Co-authored-by: Claude Opus 4.6