Skip to content

Extend test coverage#91

Merged
evgeni merged 3 commits into
developfrom
ls/tests_ext
Jun 17, 2026
Merged

Extend test coverage#91
evgeni merged 3 commits into
developfrom
ls/tests_ext

Conversation

@stejskalleos

Copy link
Copy Markdown
Collaborator

This PR has been entirely generated by AI.
I want to use it as a proof of concept for extending test coverage in the plugin repository.

Co-authored-by: Claude Opus 4.6

@stejskalleos
stejskalleos marked this pull request as ready for review June 11, 2026 07:48
@stejskalleos stejskalleos changed the title [WIP] Extend test coverage Extend test coverage Jun 11, 2026
Comment thread app/lib/google_cloud_compute/compute_attributes.rb
@stejskalleos
stejskalleos force-pushed the ls/tests_ext branch 2 times, most recently from 4931963 to dad7607 Compare June 11, 2026 12:16
@stejskalleos

Copy link
Copy Markdown
Collaborator Author

@arvind4501 any other comments or can we merge?

Comment thread app/controllers/foreman_google/api/v2/compute_resources_extensions.rb Outdated
Comment thread app/models/foreman_google/google_compute.rb Outdated
Co-authored-by: Claude Opus 4.6
Comment thread app/models/foreman_google/google_compute.rb Outdated
Comment thread test/models/foreman_google/gce_test.rb Outdated
Comment thread test/models/foreman_google/gce_test.rb
@stejskalleos
stejskalleos requested a review from evgeni June 15, 2026 12:24

@evgeni evgeni left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall this feels a tad too verbose (as expected from AI), but I have no experience with the Google compute integration to judge how useful those tests are

Comment thread test/models/foreman_google/gce_test.rb Outdated
Comment thread test/models/foreman_google/gce_test.rb Outdated
Comment thread test/models/foreman_google/gce_test.rb
@stejskalleos

Copy link
Copy Markdown
Collaborator Author

🍏 Ruby 3.3 tests are green

@evgeni

evgeni commented Jun 16, 2026

Copy link
Copy Markdown
Member

🍏 Ruby 3.3 tests are green

Which part of this PR made them work on 3.3? I thought this is purely a "increase coverage" PR, not "fix compatibility with 3.3"?

@stejskalleos

Copy link
Copy Markdown
Collaborator Author

I thought this is purely a "increase coverage" PR, not "fix compatibility with 3.3"?

Correct, I just celebrated that 3.3 is green 🥳

@evgeni
evgeni merged commit 730346f into develop Jun 17, 2026
13 checks passed
@evgeni
evgeni deleted the ls/tests_ext branch June 17, 2026 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants