Add support for authenticated registries#245
Merged
evgeni merged 2 commits intotheforeman:masterfrom Mar 6, 2026
Merged
Conversation
ehelms
force-pushed
the
add-auth-file-support
branch
from
2926317 to
ed0815f
Compare
ehelms
force-pushed
the
add-auth-file-support
branch
2 times, most recently
from
cf006d9 to
24bbeef
Compare
pablomh
reviewed
Jan 9, 2026
pablomh
reviewed
Jan 9, 2026
ehelms
force-pushed
the
add-auth-file-support
branch
from
24bbeef to
812ded7
Compare
pablomh
reviewed
Jan 14, 2026
ehelms
force-pushed
the
add-auth-file-support
branch
6 times, most recently
from
ed5d92d to
b90a0a2
Compare
pablomh
reviewed
Jan 16, 2026
pablomh
reviewed
Jan 16, 2026
pablomh
reviewed
Jan 16, 2026
pablomh
reviewed
Jan 16, 2026
ehelms
force-pushed
the
add-auth-file-support
branch
from
b90a0a2 to
728ce15
Compare
Contributor
|
This has worked fine with #369, so I guess that my recommendation could be ammended if needed later. |
ehelms
force-pushed
the
add-auth-file-support
branch
from
728ce15 to
bbb6195
Compare
pablomh
reviewed
Jan 20, 2026
ehelms
force-pushed
the
add-auth-file-support
branch
from
bbb6195 to
edc5cb2
Compare
Contributor
|
Thinking about this, how would it fit with future rootless containers which probably won't have access to the auth file? |
Member
Author
In that case, the authentication file would be located in a different location I think. Relative to the user's home for example. I am hesitant to optimize for that. |
evgeni
reviewed
Mar 5, 2026
evgeni
reviewed
Mar 5, 2026
|
|
||
| roles: | ||
| - role: pre_install | ||
| post_tasks: |
Member
There was a problem hiding this comment.
tasks already runs after roles, so why using post_tasks here?
Member
Author
There was a problem hiding this comment.
Cause that ordering is not obvious, while I find post_tasks to be self-documenting in terms of order.
evgeni
reviewed
Mar 5, 2026
evgeni
reviewed
Mar 5, 2026
| --- | ||
| redis_container_image: quay.io/sclorg/redis-6-c9s | ||
| redis_container_tag: "latest" | ||
| redis_registry_auth_file: /etc/foreman/registry-auth.json |
Member
There was a problem hiding this comment.
does it work if we set it to None here?
Suggested change
| redis_registry_auth_file: /etc/foreman/registry-auth.json | |
| redis_registry_auth_file: |
As we should try to keep the role free of Foreman specifics
Member
Author
There was a problem hiding this comment.
I suppose. This is foremanctl so it's kinda in the name? 😁
evgeni
reviewed
Mar 5, 2026
evgeni
reviewed
Mar 5, 2026
ehelms
force-pushed
the
add-auth-file-support
branch
from
edc5cb2 to
d604d55
Compare
Signed-off-by: Eric D. Helms <ericdhelms@gmail.com>
ehelms
force-pushed
the
add-auth-file-support
branch
from
d604d55 to
0cd5168
Compare
evgeni
reviewed
Mar 6, 2026
evgeni
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables foremanctl to authenticate with private registries by checking for auth files before attempting image pulls. Users can run
podman login <registry> --authfile=/etc/foreman/registry-auth.jsonand foremanctl will automatically use the credentials when available.