Conversation
Member
Author
|
Should we add a test that asserts that all settings that contain fqdns/domains have the right value? |
Member
|
What about the scenario where the user is providing a cname? |
Member
Author
|
What about it? That wasn't working for unattended url before, and doesn't work now ;) |
Member
Author
|
Tests updated |
amolpati30
reviewed
May 6, 2026
| assert server_fqdn in settings[0]['value'] | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("setting", ["administrator", "email_reply_address"]) |
There was a problem hiding this comment.
If I am referring to the administrator, should it search for a domain such as rhos-01.prod.psi.rdu2.redhat.com?
Member
Author
There was a problem hiding this comment.
that's what the test does. yeah
There was a problem hiding this comment.
Ah, I was testing this, but with the patch it was not showing the correct result—possibly due to some issues on my server. I tried it on a fresh server, and it works as expected.
amolpati30
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are you introducing these changes? (Problem description, related links)
Foreman uses the
domainandfqdnsettings (which default to their respective values from Facter) to calculate several defaults for URL and E-mail related settings. As our containers don't have a correct FQDN (since 4ef4632), this creates wrong defaults, breaking certain workflows.See #482 for details.
What are the changes introduced in this pull request?
fqdnanddomainsettings are set to sane values.How to test this pull request
Steps to reproduce:
Checklist
Fixes: #482