Skip to content

ensure we use the right hostname when testing repo URLs#496

Merged
ehelms merged 1 commit intomasterfrom
better-url-tests
May 6, 2026
Merged

ensure we use the right hostname when testing repo URLs#496
ehelms merged 1 commit intomasterfrom
better-url-tests

Conversation

@evgeni
Copy link
Copy Markdown
Member

@evgeni evgeni commented May 6, 2026

Why are you introducing these changes? (Problem description, related links)

The application generates links and we should assert that the generated links are valid.
However, as the FQDN of the application might not be reachable from the place the tests run from, we used to override the "host" (netloc) part of the URL with the IP address we know from the SSH config.
That means that if the application generates a link with the wrong host, we don't notice it, as we override it.

Related:

What are the changes introduced in this pull request?

  • Instead of overriding the host in the URL, only override it at the connection level, ensuring the right hostname is tested in the URL.

How to test this pull request

Steps to reproduce:

  • Tests should cover this

Checklist

  • Tests added/updated (if applicable)
  • Documentation updated (if applicable)

@ehelms ehelms merged commit 767e614 into master May 6, 2026
12 checks passed
@ehelms ehelms deleted the better-url-tests branch May 6, 2026 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants