ensure we use the right hostname when testing repo URLs#496
Merged
Conversation
ehelms
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are you introducing these changes? (Problem description, related links)
The application generates links and we should assert that the generated links are valid.
However, as the FQDN of the application might not be reachable from the place the tests run from, we used to override the "host" (netloc) part of the URL with the IP address we know from the SSH config.
That means that if the application generates a link with the wrong host, we don't notice it, as we override it.
Related:
What are the changes introduced in this pull request?
How to test this pull request
Steps to reproduce:
Checklist