Completed Milestone 1: Core Polish & Documentation#16
Open
theluke-dot-dev wants to merge 4 commits intomasterfrom
Open
Completed Milestone 1: Core Polish & Documentation#16theluke-dot-dev wants to merge 4 commits intomasterfrom
theluke-dot-dev wants to merge 4 commits intomasterfrom
Conversation
This milestone includes: - Comprehensive docstrings for all core modules. - Resolution of the TODO in LagomResolver for robust dependency checking. - Implementation of SimpleCommandHandlerResolver for non-DI use cases. - Enhanced README with detailed conceptual overview and usage examples for both resolvers. - Setup of test coverage reporting with coverage.py and pytest-cov. - Creation of CONTRIBUTING.md with developer guidance.
… enhanced the tests. - I modified `LagomResolver` to use `container.partial`, ensuring that `shared_deps` and `container_updater` functionalities are preserved. - I ensured that `UnresolvableType` errors from `lagom.partial` are correctly caught and wrapped in `UnresolvedDependencyError`. - I added specific tests for `shared_deps` to verify singleton behavior through the resolver. - I added specific tests for `container_updater` to verify dynamic dependency provision and error handling for missing dependencies through the updater context.
Reformatted the following files using black: - src/vistral/command_bus/tests/test_simple_resolver.py - src/vistral/contrib/lagom.py - src/vistral/contrib/tests/test_lagom.py
I ran isort on the following files to correct import formatting: - src/vistral/command_bus/tests/test_simple_resolver.py - src/vistral/contrib/exceptions.py - src/vistral/contrib/tests/test_lagom.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This milestone includes: