Skip to content

fix(ci): allow stable version alignment on premain promotion #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paytheory merged 1 commit into from
Mar 5, 2026
Merged

fix(ci): allow stable version alignment on premain promotion #94

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions scripts/verify-version-alignment.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,10 @@ if [[ -z "${expected}" ]]; then
fi

if [[ "${observed_version}" != "${expected}" ]]; then
# When merging prerelease work into `main`, allow checks to validate against the `premain` prerelease manifest.
# This prevents false failures during promotion PRs and the immediate post-merge push; the subsequent main
# release PR will enforce stable alignment.
if [[ "${branch}" == "main" && "${observed_version}" == *"-rc"* && -f ".release-please-manifest.premain.json" ]]; then
# Promotion PRs (premain -> main) and immediate post-merge pushes may still carry prerelease versions.
# Allow alignment against the premain prerelease manifest; the subsequent release PR on `main` will
# enforce stable alignment.
expected="$(
python3 - <<PY
import json
Expand All @@ -97,6 +97,20 @@ print(data.get(".", ""))
PY
)"
manifest=".release-please-manifest.premain.json"
elif [[ "${branch}" == "premain" && "${observed_version}" != *"-rc"* && -f ".release-please-manifest.json" ]]; then
# Promotion PRs (staging -> premain) and immediate post-merge pushes start from the latest stable
# baseline. Allow alignment against the stable manifest; the subsequent prerelease PR on `premain`
# will bump versions and enforce prerelease alignment.
expected="$(
python3 - <<PY
import json
from pathlib import Path

data = json.loads(Path(".release-please-manifest.json").read_text(encoding="utf-8"))
print(data.get(".", ""))
PY
)"
manifest=".release-please-manifest.json"
fi
fi

Expand Down
Loading