Skip to content

ENH: Use exactextract by default for zonalstats calculation#181

Draft
KriWay-LV wants to merge 45 commits into
theroggy:mainfrom
KriWay-LV:feature/exactextract-vs-pyqgis
Draft

ENH: Use exactextract by default for zonalstats calculation#181
KriWay-LV wants to merge 45 commits into
theroggy:mainfrom
KriWay-LV:feature/exactextract-vs-pyqgis

Conversation

@KriWay-LV
Copy link
Copy Markdown
Collaborator

@KriWay-LV KriWay-LV commented Apr 10, 2025

PR changes the default for zonalstats calculation to "exactextract".

Exactextract has a lot more options regarding which (parts of) pixels are counted in the zonal statistics and which aren't. Based on some tests:

  • the negative buffer applied on the parcels was ???
  • the stats being calculated were changed to ???

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 10, 2025

Codecov Report

❌ Patch coverage is 60.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 35.65%. Comparing base (867974e) to head (cc950a1).

Files with missing lines Patch % Lines
...zonal_stats_bulk/_zonal_stats_bulk_exactextract.py 40.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
+ Coverage   34.60%   35.65%   +1.05%     
==========================================
  Files          37       38       +1     
  Lines        4890     4894       +4     
==========================================
+ Hits         1692     1745      +53     
+ Misses       3198     3149      -49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KriWay-LV KriWay-LV requested a review from theroggy May 7, 2025 11:33
@KriWay-LV KriWay-LV marked this pull request as draft May 9, 2025 08:26
@KriWay-LV KriWay-LV marked this pull request as ready for review May 12, 2025 14:36
@theroggy theroggy changed the title ENH: Use exactextract for zonalstats calculation ENH: Use exactextract by default for zonalstats calculation May 12, 2025
Copy link
Copy Markdown
Owner

@theroggy theroggy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already some first small remarks while waiting on the performance/result tests being done...

Comment thread cropclassification/preprocess/_timeseries_calc_openeo.py
Comment thread cropclassification/util/zonal_stats_bulk/__init__.py Outdated
Comment thread debug.log Outdated
Comment thread CHANGELOG.md Outdated
Comment thread cropclassification/general.ini
@KriWay-LV KriWay-LV requested a review from theroggy May 13, 2025 05:50
@KriWay-LV KriWay-LV marked this pull request as draft May 11, 2026 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants