Skip to content

BUG: Failing test_calc_index_by_gdal_raster #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KriWay-LV wants to merge 10 commits into
base: main
Choose a base branch
from
+144 −10
Open

BUG: Failing test_calc_index_by_gdal_raster #217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f8d67a1
expect float16 in stead of float32
KriWay-LV Apr 30, 2026
0811a8a
undo the changes
KriWay-LV Apr 30, 2026
6e8b0b9
redo changes
KriWay-LV May 4, 2026
b4b70b9
pinned version rasterio and tests with minimal python 3.12
KriWay-LV May 4, 2026
9464546
use python 3.13 for macos-latest test
KriWay-LV May 5, 2026
16c7b74
skip tests when certain rasterio version
KriWay-LV May 5, 2026
77090f6
rasterio not pinned
KriWay-LV May 5, 2026
0b61113
set minimal python version to 3.10
KriWay-LV May 5, 2026
e750708
refactor yml
KriWay-LV May 5, 2026
6f2bdc6
refactor yml
KriWay-LV May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
matrix:
os: [ubuntu-latest]
dev: [false]
python: ["3.10", "3.11", "3.12"]
python: ["3.10", "3.11", "3.12", "3.13"]
env: ["latest"]
# Use openblas instead of mkl saves 600 MB. Linux OK, 50% slower on Windows and OSX!
extra: ["nomkl"]
Expand All @@ -44,7 +44,7 @@ jobs:
- env: latest
os: windows-latest
dev: false
python: "3.12"
python: "3.13"

steps:
- uses: actions/checkout@v6
Expand Down
150 changes: 142 additions & 8 deletions tests/test_raster_index_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,11 +126,38 @@ def test_calc_index_invalid(tmp_path):
"index, pixel_type, process_options, expected_bands",
[
("dprvi", "BYTE", {}, ["dprvi"]),
("dprvi", "FLOAT16", None, ["dprvi"]),
pytest.param(
"dprvi",
"FLOAT16",
None,
["dprvi"],
marks=pytest.mark.skipif(
rasterio.__version__ == "1.4.4",
reason="Requires rasterio <> 1.4.4",
),
),
("dprvi", "FLOAT32", {}, ["dprvi"]),
("rvi", "BYTE", {}, ["rvi"]),
("vvdvh", "FLOAT16", {}, ["vvdvh"]),
("sarrgb", "FLOAT16", {}, ["vv", "vh", "vvdvh"]),
pytest.param(
"vvdvh",
"FLOAT16",
{},
["vvdvh"],
marks=pytest.mark.skipif(
rasterio.__version__ == "1.4.4",
reason="Requires rasterio <> 1.4.4",
),
),
pytest.param(
"sarrgb",
"FLOAT16",
{},
["vv", "vh", "vvdvh"],
marks=pytest.mark.skipif(
rasterio.__version__ == "1.4.4",
reason="Requires rasterio <> 1.4.4",
),
),
("sarrgb", "FLOAT32", {"log10": True}, ["vvdb", "vhdb", "vvdvhdb"]),
("sarrgb", "BYTE", {"log10": True}, ["vvdb", "vhdb", "vvdvhdb"]),
(
Expand Down Expand Up @@ -211,7 +238,26 @@ def test_calc_index_s1_error(


@pytest.mark.parametrize(
"index, pixel_type", [("ndvi", "BYTE"), ("ndvi", "FLOAT16"), ("bsi", "FLOAT16")]
"index, pixel_type",
[
("ndvi", "BYTE"),
pytest.param(
"ndvi",
"FLOAT16",
marks=pytest.mark.skipif(
rasterio.__version__ == "1.4.4",
reason="Requires rasterio <> 1.4.4",
),
),
pytest.param(
"bsi",
"FLOAT16",
marks=pytest.mark.skipif(
rasterio.__version__ == "1.4.4",
reason="Requires rasterio <> 1.4.4",
),
),
],
)
def test_calc_index_s2(tmp_path, index, pixel_type):
# Prepare test data
Expand All @@ -236,20 +282,108 @@ def test_calc_index_s2(tmp_path, index, pixel_type):
[
("ndvi", "BYTE", gdal.GDT_UInt16, 32676, ["B04", "B08", "b1"], "uint8", 255),
("ndvi", "BYTE", gdal.GDT_Float32, np.nan, ["B04", "B08"], "uint8", 255),
("ndvi", "FLOAT16", gdal.GDT_UInt16, 32676, ["B04", "B08"], "float32", np.nan),
(
pytest.param(
"ndvi",
"FLOAT16",
gdal.GDT_UInt16,
32676,
["B04", "B08"],
"float16",
np.nan,
marks=pytest.mark.skipif(
rasterio.__version__ < "1.5", reason="Requires rasterio 1.5 or higher"
),
),
pytest.param(
"ndvi",
"FLOAT16",
gdal.GDT_Float32,
np.nan,
["B04", "B08"],
"float16",
np.nan,
marks=pytest.mark.skipif(
rasterio.__version__ < "1.5", reason="Requires rasterio 1.5 or higher"
),
),
pytest.param(
"ndvi",
"FLOAT16",
gdal.GDT_UInt16,
32676,
["B04", "B08"],
"float32",
np.nan,
marks=pytest.mark.skipif(
rasterio.__version__ >= "1.5" or rasterio.__version__ == "1.4.4",
reason="Requires rasterio < 1.5",
),
),
pytest.param(
"ndvi",
"FLOAT16",
gdal.GDT_Float32,
np.nan,
["B04", "B08"],
"float32",
np.nan,
marks=pytest.mark.skipif(
rasterio.__version__ >= "1.5" or rasterio.__version__ == "1.4.4",
reason="Requires rasterio < 1.5",
),
),
("dprvi", "BYTE", gdal.GDT_UInt16, 32676, ["VH", "VV"], "uint8", 255),
("dprvi", "BYTE", gdal.GDT_Float32, np.nan, ["VH", "VV"], "uint8", 255),
("dprvi", "FLOAT16", gdal.GDT_UInt16, 32676, ["VH", "VV"], "float32", np.nan),
("dprvi", "FLOAT16", gdal.GDT_Float32, np.nan, ["VH", "VV"], "float32", np.nan),
pytest.param(
"dprvi",
"FLOAT16",
gdal.GDT_UInt16,
32676,
["VH", "VV"],
"float16",
np.nan,
marks=pytest.mark.skipif(
rasterio.__version__ < "1.5", reason="Requires rasterio 1.5 or higher"
),
),
pytest.param(
"dprvi",
"FLOAT16",
gdal.GDT_Float32,
np.nan,
["VH", "VV"],
"float16",
np.nan,
marks=pytest.mark.skipif(
rasterio.__version__ < "1.5", reason="Requires rasterio 1.5 or higher"
),
),
pytest.param(
"dprvi",
"FLOAT16",
gdal.GDT_UInt16,
32676,
["VH", "VV"],
"float32",
np.nan,
marks=pytest.mark.skipif(
rasterio.__version__ >= "1.5" or rasterio.__version__ == "1.4.4",
reason="Requires rasterio < 1.5",
),
),
pytest.param(
"dprvi",
"FLOAT16",
gdal.GDT_Float32,
np.nan,
["VH", "VV"],
"float32",
np.nan,
marks=pytest.mark.skipif(
rasterio.__version__ >= "1.5" or rasterio.__version__ == "1.4.4",
reason="Requires rasterio < 1.5",
),
),
],
)
def test_calc_index_by_gdal_raster(
Expand Down
Loading