Merged
Conversation
klimick
commented
Dec 4, 2025
| $consumedMessages[$delivery->exchange][] = $delivery->message->body; | ||
| $delivery->ack(); | ||
| if (\count($consumedMessages[$delivery->exchange]) === $messageCount) { | ||
| if (\count($consumedMessages[$delivery->exchange]) === $messageCount && !$deferred->isComplete()) { |
Contributor
Author
There was a problem hiding this comment.
After the changes in the Consumer, a race condition appeared here.
Here is a minimized race condition.
/** @var DeferredFuture<null> */
$deferred = new DeferredFuture();
/** @var \ArrayObject<int, string> */
$consumed = new \ArrayObject();
$callback = static function () use ($consumed, $deferred) {
$consumed[] = 'elem';
// Simulates an I/O operation (e.g., $delivery->ack())
delay(0.1);
// After resuming, both fibers will see that \count($consumed) === 2
if (\count($consumed) === 2) {
// Both fibers attempt to complete the same DeferredFuture
// Error: the operation is no longer pending
$deferred->complete();
}
};
await([
async($callback),
async($callback),
$deferred->getFuture(),
]);
kafkiansky
approved these changes
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #80