fix: zeroize full string capacity when building shroudedstring from string#14
Open
mooncitydev wants to merge 1 commit intothesis:mainfrom
Open
fix: zeroize full string capacity when building shroudedstring from string#14mooncitydev wants to merge 1 commit intothesis:mainfrom
mooncitydev wants to merge 1 commit intothesis:mainfrom
Conversation
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
write_and_zeroize_sourceonly clearedlenbytes of the source buffer; any spare capacity in the heap-backedStringcould still retain secret material after the copy.Fix
Call
Zeroize::zeroizeon theStringafter the copy completes so the entire allocation (including slack capacity) is cleared, consistent with thezeroizecrate behavior forString.made by mooncitydev