Skip to content

ASoC: SOF: imx8m: add SAI2,5,6,7 #4391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
plbossart merged 1 commit into from
Sep 25, 2023
Merged

ASoC: SOF: imx8m: add SAI2,5,6,7 #4391

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions sound/soc/sof/imx/imx8m.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,17 @@ static struct snd_soc_dai_driver imx8m_dai[] = {
.channels_max = 32,
},
},
{
.name = "sai2",
.playback = {
.channels_min = 1,
.channels_max = 32,
},
.capture = {
.channels_min = 1,
.channels_max = 32,
},
},
{
.name = "sai3",
.playback = {
Expand All @@ -315,6 +326,39 @@ static struct snd_soc_dai_driver imx8m_dai[] = {
.channels_max = 32,
},
},
{
Copy link
Copy Markdown
Member

@plbossart plbossart May 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"There is no SAI4" would be a highly unusual way of designing hardware?

The first Google search gives me this
image

Copy link
Copy Markdown

@paulstelian97 paulstelian97 May 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect that NXP won't support HDMI in Sound Open Firmware, so skipping it is likely fine here. If that changes at some point then fair game though.

Copy link
Copy Markdown
Member

@plbossart plbossart May 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"skipped - not supported" is different to "does not exist"...

Copy link
Copy Markdown
Author

@eurofun eurofun Jun 1, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of imx8m in SOF is a bit unfortunate (or I just don't understand it) because NXP i.MX8M does not even have a DSP. So it is more about i.MX8MPlus...
imx8 and imx8ulp don't have a SAI 4 with external connections as far as I saw. They do have more SAIs than are defined in imx8.c and imx8ulp.c but I concerned myself only with imx8mp.

.name = "sai5",
.playback = {
.channels_min = 1,
.channels_max = 32,
},
.capture = {
.channels_min = 1,
.channels_max = 32,
},
},
{
.name = "sai6",
.playback = {
.channels_min = 1,
.channels_max = 32,
},
.capture = {
.channels_min = 1,
.channels_max = 32,
},
},
{
.name = "sai7",
.playback = {
.channels_min = 1,
.channels_max = 32,
},
.capture = {
.channels_min = 1,
.channels_max = 32,
},
},
};

static int imx8m_dsp_set_power_state(struct snd_sof_dev *sdev,
Expand Down