basefw: add support for fw config query for context save by RanderWang · Pull Request #8428 · thesofproject/sof

RanderWang · 2023-11-01T05:15:07Z

If CONFIG_ADSP_IMR_CONTEXT_SAVE is enabled, base fw will report fw_context_save is supported to host

src/audio/base_fw.c

RanderWang · 2023-11-01T08:11:54Z

on kernel side, I change the default value of fw_context_save on TGL & MTL to ture, unless fw overrides it

btian1

just a suggestion in comments:
If CONFIG_ADSP_IMR_CONTEXT_SAVE is enabled, base fw will report
fw_context_save is supported to driver. Driver will assume fw doesn't
support this feature if it is not reported.

ujfalusi · 2023-11-02T07:42:27Z

just a suggestion in comments: If CONFIG_ADSP_IMR_CONTEXT_SAVE is enabled, base fw will report fw_context_save is supported to driver. Driver will assume fw doesn't support this feature if it is not reported.

The assumption is that the context save is supported if IMR is supported. We need negative flagging for this.

src/audio/base_fw.c

RanderWang · 2023-11-03T07:17:05Z

just a suggestion in comments: If CONFIG_ADSP_IMR_CONTEXT_SAVE is enabled, base fw will report fw_context_save is supported to driver. Driver will assume fw doesn't support this feature if it is not reported.

The assumption is that the context save is supported if IMR is supported. We need negative flagging for this.

@ujfalusi how about ID now ? We don't need negative flag sine the default value in kernel is true, not false.

lgirdwood

Just need to align new IDs

lgirdwood · 2023-11-03T16:52:50Z

src/include/ipc4/base_fw.h

+	IPC4_FW_CONTEXT_SAVE,
 	/* Max config parameter id */
-	IPC4_MAX_FW_CFG_PARAM = IPC4_FW_CFG_PARAMS_COUNT - 1,
+	IPC4_MAX_FW_CFG_PARAM = IPC4_FW_CONTEXT_SAVE - 1,


@RanderWang @ujfalusi @mwasko @marcinszkudlinski to be on the safe side - can we add our new Intel reserved IDs as part of this PR and I think its going to be better if we also assign the numbers when updating this enum. i.e there is no ambiguos enum, developers should always see

IPC4_SOME_ENUM = NUMBER,

good idea! I use 100, big enough for 10 years.

good idea! I use 100, big enough for 10 years.

be careful, our industry has a bad experinces with quotes like these ;)

RanderWang · 2023-11-06T06:32:42Z

reserve 100 for this config

RanderWang · 2023-11-08T05:33:07Z

@lgirdwood sync latest config from ref fw.

RanderWang · 2023-11-13T09:09:49Z

@lgirdwood I reserved 3 id, how about it ? Thanks!

src/include/ipc4/base_fw.h

lgirdwood · 2023-11-13T14:51:59Z

src/include/ipc4/base_fw.h

+	/* Intel reserved */
+	IPC4_INTEL_RESRVED_29 = 29,
+	IPC4_INTEL_RESRVED_30 = 30,
+	IPC4_INTEL_RESRVED_31 = 31,


If we are using 31 we can name it using its real name.

RanderWang · 2023-11-14T05:08:12Z

@lgirdwood update the ID name

lgirdwood

@mwasko this PR also reserves the in-use IDs until some process is created to align.

lgirdwood · 2023-11-14T14:52:22Z

@ujfalusi pls review, does kernel align or does it require a similar PR ?

kv2019i

A few comments on the code documentation, otherwise looks good.

src/include/ipc4/base_fw.h

Update the basefw config query. Signed-off-by: Rander Wang <rander.wang@intel.com>

lgirdwood · 2023-11-17T13:08:46Z

@wszypelt @lrudyX not expecting an ID update to break, good to merge ? Thanks !

kv2019i

@mwasko @mmaka1 good to go (this reserves 29 for the new cfg id)?

kv2019i · 2023-11-20T19:14:50Z

@RanderWang can you check the CI (and/or repush if this is transient as probably is the case)?

RanderWang · 2023-11-21T01:39:02Z

SOFCI TEST

RanderWang · 2023-11-22T04:17:03Z

Will update it according to ref fw which has merged a config

If CONFIG_ADSP_IMR_CONTEXT_SAVE is enabled, base fw will report fw_context_save is supported to host. Driver will assume fw doesn't support this feature if it is not reported. Signed-off-by: Rander Wang <rander.wang@intel.com>

RanderWang · 2023-11-22T06:46:57Z

@lgirdwood @kv2019i update PR to follow ref fw https://github.com/intel-innersource/drivers.audio.firmware.cavs-ace/pull/1533

kv2019i · 2023-11-24T08:03:41Z

SOFCI TEST

RanderWang requested review from dbaluta, kv2019i, lbetlej, lgirdwood, marcinszkudlinski, mmaka1, pblaszko and plbossart as code owners November 1, 2023 05:15

RanderWang force-pushed the lib_reload_config branch from 28bd520 to 50c268f Compare November 1, 2023 05:16

RanderWang requested a review from ujfalusi November 1, 2023 05:17

RanderWang mentioned this pull request Nov 1, 2023

Query FW config to reload library thesofproject/linux#4680

Merged

ujfalusi requested changes Nov 1, 2023

View reviewed changes

src/audio/base_fw.c Outdated Show resolved Hide resolved

RanderWang force-pushed the lib_reload_config branch from 50c268f to 8f19cf0 Compare November 1, 2023 08:00

btian1 approved these changes Nov 2, 2023

View reviewed changes

lyakh reviewed Nov 2, 2023

View reviewed changes

src/audio/base_fw.c Outdated Show resolved Hide resolved

lgirdwood reviewed Nov 3, 2023

View reviewed changes

RanderWang force-pushed the lib_reload_config branch 2 times, most recently from 456d157 to 1ff2579 Compare November 6, 2023 06:13

RanderWang force-pushed the lib_reload_config branch from 1ff2579 to 9d0fea8 Compare November 8, 2023 05:32

RanderWang force-pushed the lib_reload_config branch 2 times, most recently from 6b78836 to ffb1746 Compare November 13, 2023 09:08

RanderWang force-pushed the lib_reload_config branch from ffb1746 to 29e9133 Compare November 13, 2023 09:11

lgirdwood reviewed Nov 13, 2023

View reviewed changes

RanderWang force-pushed the lib_reload_config branch from 29e9133 to 816596d Compare November 14, 2023 05:07

lgirdwood approved these changes Nov 14, 2023

View reviewed changes

kv2019i reviewed Nov 14, 2023

View reviewed changes

src/include/ipc4/base_fw.h Outdated Show resolved Hide resolved

src/include/ipc4/base_fw.h Outdated Show resolved Hide resolved

base_fw: sync config from ref fw

1b80c83

Update the basefw config query. Signed-off-by: Rander Wang <rander.wang@intel.com>

RanderWang force-pushed the lib_reload_config branch 2 times, most recently from a603a93 to c488070 Compare November 15, 2023 01:22

lgirdwood approved these changes Nov 17, 2023

View reviewed changes

ujfalusi approved these changes Nov 17, 2023

View reviewed changes

lgirdwood added this to the v2.8 milestone Nov 17, 2023

kv2019i approved these changes Nov 20, 2023

View reviewed changes

abonislawski approved these changes Nov 20, 2023

View reviewed changes

tmleman approved these changes Nov 20, 2023

View reviewed changes

basefw: add support for fw config query for context save

7b2cd87

If CONFIG_ADSP_IMR_CONTEXT_SAVE is enabled, base fw will report fw_context_save is supported to host. Driver will assume fw doesn't support this feature if it is not reported. Signed-off-by: Rander Wang <rander.wang@intel.com>

RanderWang force-pushed the lib_reload_config branch from c488070 to 7b2cd87 Compare November 22, 2023 06:47

lgirdwood merged commit 472458e into thesofproject:main Nov 24, 2023

Conversation

RanderWang commented Nov 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

RanderWang commented Nov 1, 2023

Uh oh!

btian1 left a comment

Choose a reason for hiding this comment

Uh oh!

ujfalusi commented Nov 2, 2023

Uh oh!

Uh oh!

RanderWang commented Nov 3, 2023

Uh oh!

lgirdwood left a comment

Choose a reason for hiding this comment

Uh oh!

lgirdwood Nov 3, 2023

Choose a reason for hiding this comment

Uh oh!

RanderWang Nov 6, 2023

Choose a reason for hiding this comment

Uh oh!

lgirdwood Nov 7, 2023

Choose a reason for hiding this comment

Uh oh!

RanderWang commented Nov 6, 2023

Uh oh!

RanderWang commented Nov 8, 2023

Uh oh!

RanderWang commented Nov 13, 2023

Uh oh!

Uh oh!

lgirdwood Nov 13, 2023

Choose a reason for hiding this comment

Uh oh!

RanderWang Nov 14, 2023

Choose a reason for hiding this comment

Uh oh!

RanderWang commented Nov 14, 2023

Uh oh!

lgirdwood left a comment

Choose a reason for hiding this comment

Uh oh!

lgirdwood commented Nov 14, 2023

Uh oh!

kv2019i left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

lgirdwood commented Nov 17, 2023

Uh oh!

kv2019i left a comment

Choose a reason for hiding this comment

Uh oh!

kv2019i commented Nov 20, 2023

Uh oh!

RanderWang commented Nov 21, 2023

Uh oh!

RanderWang commented Nov 22, 2023

Uh oh!

RanderWang commented Nov 22, 2023

Uh oh!

kv2019i commented Nov 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

RanderWang commented Nov 1, 2023 •

edited

Loading