Merged
Conversation
This is part of eq_fir code reorganize, move headers to its own directory. Signed-off-by: Baofeng Tian <baofeng.tian@intel.com>
lyakh
reviewed
Nov 3, 2023
marc-hb
previously requested changes
Nov 7, 2023
Collaborator
marc-hb
left a comment
marc-hb
left a comment
There was a problem hiding this comment.
This PR adds eight new C files to zephyr/CMakeLists.txt but it does not seem to remove them from anywhere else. So how is this a "re-org"? Please explain in the commit message what is happening here.
lyakh
requested changes
Nov 7, 2023
marc-hb
reviewed
Nov 7, 2023
btian1
force-pushed
the
fir_refine
branch
2 times, most recently
from
74efa04 to
524154b
Compare
lyakh
reviewed
Nov 8, 2023
Move out ipc3 and ipc4 specific code to corresponding source file. Also, move some common functions to header file. Signed-off-by: Baofeng Tian <baofeng.tian@intel.com>
lyakh
approved these changes
Nov 9, 2023
singalsu
reviewed
Nov 10, 2023
Simplify set parameters, also add source buffer parameter setting. Signed-off-by: Baofeng Tian <baofeng.tian@intel.com>
singalsu
approved these changes
Nov 16, 2023
Collaborator
singalsu
left a comment
singalsu
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for the clean up work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.