Tools: Topology2: Add widget class RTNR#8449
Merged
kv2019i merged 2 commits intothesofproject:mainfrom Nov 16, 2023
Merged
Conversation
This patch allows to build topologies to use the RTNR component. Two bytes control blobs are converted from topology1 to IPC4 format. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This patch adds build of hda-generic development topologies to test RTNR component with all s16/s24/s32 formats. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
Member
|
@kv2019i any comments ? |
kv2019i
approved these changes
Nov 13, 2023
Collaborator
jsarha
approved these changes
Nov 16, 2023
Contributor
jsarha
left a comment
jsarha
left a comment
There was a problem hiding this comment.
Looks syntactically correct. Would be helpful, if it would at least once be written somewhere what RTNR stands for. I had to use Google to know what this for 😅.
Collaborator
Author
True, I could have added same pointer as in firmware. This was min. effort to get component to run with supplied stubs library. We have now two NR solutions in SOF, though closed library licensing is needed to use them. Hope the companies can contribute to these files e.g. links to their products web pages for their new customers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.