copier: store gateway config in copier_data#8558
Closed
plbossart wants to merge 1 commit intothesofproject:mainfrom
Closed
copier: store gateway config in copier_data#8558plbossart wants to merge 1 commit intothesofproject:mainfrom
plbossart wants to merge 1 commit intothesofproject:mainfrom
Conversation
Calculate actual size of copier module gateway config. Copy and store it in copier_data. It needs to be available even after copier is created e.g. during SET_PIPELINE_STATE IPC when dai_config_dma_channel() is called second time and DMA config is used to assign dma_channel_id value. Signed-off-by: Ievgen Ganakov <ievgen.ganakov@intel.com>
plbossart
requested review from
RanderWang,
abonislawski and
pblaszko
as code owners
Member
Author
Contributor
|
I tested multiple times in LNLM_SDW_AIOC but still seeing |
Collaborator
|
@plbossart please check 4cc9d54. At first we save the gateway config, but it was deleted |
lyakh
requested changes
Dec 1, 2023
| if (copier->gtw_cfg.config_length) { | ||
| gtw_cfg_size = copier->gtw_cfg.config_length << 2; | ||
| gtw_cfg = rzalloc(SOF_MEM_ZONE_RUNTIME, 0, SOF_MEM_CAPS_RAM, | ||
| gtw_cfg_size); |
Collaborator
There was a problem hiding this comment.
please use rmalloc() - you overwrite it completely 5 lines later
btian1
reviewed
Dec 4, 2023
| } | ||
|
|
||
| ret = memcpy_s(gtw_cfg, gtw_cfg_size, &copier->gtw_cfg.config_data, | ||
| gtw_cfg_size); |
Contributor
There was a problem hiding this comment.
why we can't directly copy data into cd->gtw_cfg with:
ret = memcpy_s(&cd->gtw_cfg, gtw_cfg_size, &copier->gtw_cfg.config_data,
gtw_cfg_size);
Contributor
|
@plbossart @fredoh9 Let me submit a proper fix for DMIC and SSP, we've already tested it internally. SNDW needs additional changes related to blob format which is now different for Linux and Windows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calculate actual size of copier module gateway config. Copy and store it in copier_data. It needs to be available even after copier is created e.g. during SET_PIPELINE_STATE IPC when dai_config_dma_channel() is called second time and DMA config is used to assign dma_channel_id value.