Add rtmidi_set_error_callback to C wrapper#359
Merged
garyscavone merged 1 commit intothestk:masterfrom Sep 9, 2025
Merged
Conversation
Contributor
|
There is a conflict, probably with the previous PR merge. Please see if you can resolve it, as I don't use the C API at all and it would take a while for me to evaluate the conflict. |
Without setting a callback, all errors are printed to stderr, which may not be desirable. Rename `data` field in wrapper struct to something more descriptive. Delete `rtmidi_error` function as the prototype mismatched the implementation. Templatize existing callback proxy class so we can reuse it for error callbacks. This is an ABI break as it adds a field to the wrapper struct.
Contributor
Author
|
@garyscavone I fixed the conflicts. The macOS CI failure looks unrelated to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without setting a callback, all errors are printed to stderr, which may not be desirable.
Rename
datafield in wrapper struct to something more descriptive.Delete
rtmidi_errorfunction as the prototype mismatched the implementation.Templatize existing callback proxy class so we can reuse it for error callbacks.
This is an ABI break as it adds a field to the wrapper struct.
Test script: